Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roundrobin: export PickerBuilder #3436

Closed
wants to merge 2 commits into from
Closed

roundrobin: export PickerBuilder #3436

wants to merge 2 commits into from

Conversation

neena
Copy link

@neena neena commented Mar 10, 2020 •
edited
Loading

I'd like to be able to use the roundrobin picker builder outside of the roundrobin balancer, as I'm writing a wrapper for picker builders. This PR exposes the PickerBuilder.

@neena
roundrobin: export PickerBuilder
0127a17 
I'd like to be able to use the roundrobin picker builder outside of the roundrobin balancer, as I'm writing a wrapper for picker builders. This PR exposes the PickerBuilder through a function.

I'm also happy to just rename `rrPickerBuilder` to `PickerBuilder` if that's preferred!
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 10, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@dfawley
Copy link
Member

dfawley commented Mar 10, 2020

Hi @neena,

Thanks for the PR. We plan on improving the base package (#3425) now that we understand common use cases a bit better than we did two years ago. Something like this should be considered along with that effort. Instead of exporting this type from here, I'd rather consolidate these kinds of things into one package (or possibly a collection of packages) focused on helpers. Thanks!

@dfawley dfawley closed this Mar 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neena @dfawley