Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addrConn: not reset backoff if update address in TransientFailure #2740

Merged
merged 2 commits into from
May 30, 2019

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Apr 4, 2019

fixes #2739

@menghanl menghanl force-pushed the update_addr_when_not_ready branch from b291c16 to a63ffd2 Compare April 8, 2019 21:40
@menghanl menghanl self-assigned this Apr 11, 2019
@menghanl menghanl force-pushed the update_addr_when_not_ready branch 12 times, most recently from 58d71dd to 302f2af Compare April 24, 2019 20:18
@menghanl menghanl force-pushed the update_addr_when_not_ready branch from 302f2af to 9ca7444 Compare May 3, 2019 20:21
@dfawley dfawley self-requested a review May 9, 2019 20:10
@dfawley dfawley assigned dfawley and unassigned menghanl May 9, 2019
clientconn.go Outdated
@@ -768,25 +767,35 @@ func (ac *addrConn) connect() error {

// tryUpdateAddrs tries to update ac.addrs with the new addresses list.
//
// It checks whether current connected address of ac is in the new addrs list.
// If ac is Connecting, it returnes false. The caller should tear down the ac
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*returns

@dfawley dfawley assigned menghanl and unassigned dfawley May 23, 2019
@menghanl menghanl merged commit 82fdf27 into grpc:master May 30, 2019
@menghanl menghanl deleted the update_addr_when_not_ready branch May 30, 2019 20:13
@dfawley dfawley added this to the 1.22 Release milestone Jun 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client reconnects way too frequently
2 participants