vet: disallow importing "unsafe" #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Apr 25, 2018
vet.sh
Outdated
| @@ -49,6 +49,7 @@ if git status --porcelain | read; then | |||
| fi | |||
|
|
|||
| git ls-files "*.go" | xargs grep -L "\(Copyright [0-9]\{4,\} gRPC authors\)\|DO NOT EDIT" 2>&1 | tee /dev/stderr | (! read) | |||
| git ls-files "*.go" | xargs grep -l "\"unsafe\"" 2>&1 | grep -v 'primitives_test.go' | tee /dev/stderr | (! read) | |||
The exit status is 1 if no match was found.
dfawley
reviewed
Apr 25, 2018
vet.sh
Outdated
| @@ -49,7 +49,7 @@ if git status --porcelain | read; then | |||
| fi | |||
|
|
|||
| git ls-files "*.go" | xargs grep -L "\(Copyright [0-9]\{4,\} gRPC authors\)\|DO NOT EDIT" 2>&1 | tee /dev/stderr | (! read) | |||
| git ls-files "*.go" | xargs grep -l "\"unsafe\"" 2>&1 | grep -v '_test.go' | tee /dev/stderr | (! read) | |||
| git ls-files "*.go" | xargs grep -l "\"unsafe\"" 2>&1 | (! grep -v '_test.go') | tee /dev/stderr | (! read) | |||
There was a problem hiding this comment.
Since the exit status is being checked, I think you can remove the | tee /dev/stderr | (! read).
EDIT: Same with above?
dfawley
approved these changes
Apr 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2022