Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport: fix race that could lead to the server closing a connection due to too many pings #1905

Merged
merged 1 commit into from
Mar 12, 2018
Merged

transport: fix race that could lead to the server closing a connection due to too many pings #1905

merged 1 commit into from
Mar 12, 2018

Conversation

MakMukhi
Copy link
Contributor

@MakMukhi MakMukhi commented Mar 7, 2018 •
edited by dfawley
Loading

fixes #1882

Eliminate race which causes a ping to be scheduled between pingStrike counter being reset and data being scheduled.

@MakMukhi MakMukhi requested a review from dfawley March 7, 2018 18:41
@MakMukhi MakMukhi mentioned this pull request Mar 7, 2018
Closed
@dfawley dfawley changed the title Fix race: Eliminate race which causes ping to scheduled between pingStrike counter being reset and data being scheduled. transport: fix race that could lead to the server closing a connection due to too many pings Mar 7, 2018
@janardhan1993 janardhan1993 mentioned this pull request Mar 8, 2018
Closed
@dfawley dfawley merged commit 3a9e1ba into grpc:master Mar 12, 2018
@menghanl menghanl added this to the 1.11 Release milestone Mar 27, 2018
lyuxuan pushed a commit to lyuxuan/grpc-go that referenced this pull request Apr 4, 2018
@MakMukhi @lyuxuan
Reset ping strike counter right before sending out data. (grpc#1905)
714bb33 
Eliminate race which causes a ping to be scheduled between pingStrike counter being reset and data being scheduled.
@MakMukhi MakMukhi deleted the fix_1882 branch May 4, 2018 02:03
@jlbud
Copy link

jlbud commented Jul 25, 2018

1.There is only one client, and it still has this concurrency problem:
rpc error: code = Unavailable desc = transport is closing,
2.This is my current version of gRPC:
980d9e0 - ClientConn: add Target() returning target string (#2233)

@dfawley
Copy link
Member

dfawley commented Jul 25, 2018

@Kevin005 could you file an issue for this, please?

@jlbud
Copy link

jlbud commented Jul 26, 2018

As a proto server, we are using a function of Golang:
()unsafe.Pointer()

@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Bug
Projects
None yet
Milestone
1.11 Release
Development

Successfully merging this pull request may close these issues.

Unexpected transport closing: too many pings from client
4 participants
@MakMukhi @jlbud @dfawley @menghanl