Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Go1.6 support #1492

Merged
merged 3 commits into from
Oct 4, 2017
Merged

Remove Go1.6 support #1492

merged 3 commits into from
Oct 4, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 29, 2017

No description provided.

Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉👍👍👍

Also change/remove this: https://github.com/grpc/grpc-go/tree/master/examples#prerequisites?

@dfawley
Copy link
Member Author

dfawley commented Aug 30, 2017

Also change/remove this: https://github.com/grpc/grpc-go/tree/master/examples#prerequisites?

Nice. I only grepped for 1.6, not 1.5! Done.

@dfawley dfawley modified the milestone: 1.7 Release Aug 31, 2017
@dfawley dfawley added the Type: Dependencies Updating/adding/removing dependencies label Aug 31, 2017
@dfawley dfawley force-pushed the go16 branch 3 times, most recently from 254e43c to e067d3d Compare October 3, 2017 21:52
Copy link
Member Author

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL; this is finally ready to go with AppEngine on 1.8.

Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@dfawley dfawley merged commit c840555 into grpc:master Oct 4, 2017
@broady
Copy link
Contributor

broady commented Oct 5, 2017

FYI, 1.8 on GAE isn't GA yet.

jhump added a commit to jhump/protoreflect that referenced this pull request Oct 5, 2017
menghanl added a commit that referenced this pull request Oct 6, 2017
rakyll added a commit to rakyll/opencensus-go that referenced this pull request Oct 12, 2017
Once grpc/grpc-go#1492 is merged,
we will entirely remove the dependency to golang.org/x/net.
rakyll pushed a commit to census-instrumentation/opencensus-go that referenced this pull request Oct 15, 2017
Once grpc/grpc-go#1492 is merged,
we will entirely remove the dependency to golang.org/x/net.
dfawley added a commit that referenced this pull request Oct 16, 2017
dfawley added a commit that referenced this pull request Oct 16, 2017
dfawley added a commit to dfawley/grpc-go that referenced this pull request Oct 20, 2017
dfawley added a commit to dfawley/grpc-go that referenced this pull request Oct 20, 2017
@dfawley dfawley deleted the go16 branch July 6, 2018 18:04
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants