-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Go1.6 support #1492
Remove Go1.6 support #1492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉👍👍👍
Also change/remove this: https://github.com/grpc/grpc-go/tree/master/examples#prerequisites?
Nice. I only grepped for 1.6, not 1.5! Done. |
254e43c
to
e067d3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL; this is finally ready to go with AppEngine on 1.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again
FYI, 1.8 on GAE isn't GA yet. |
Once grpc/grpc-go#1492 is merged, we will entirely remove the dependency to golang.org/x/net.
Once grpc/grpc-go#1492 is merged, we will entirely remove the dependency to golang.org/x/net.
This reverts commit c840555.
No description provided.