Use codes.Code.String() rather than logging integers #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamird
changed the title
This produces better human-readable error messages.
|
This is green. Who's the maintainer of this project now? Please have a look. |
|
This is actually a behavior change. |
|
Yeah, it's a minor behaviour change, but the current errors are quite difficult to deal with. Do you think someone is depending on the string representation of this error? |
|
I don't know of anyone depending on the string. |
|
@menghanl so, is this good to go? |
|
Merging this because depending on the string doesn't look like the right thing. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This produces better human-readable error messages.