Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WireLength is not set on the stats.InPayload used as input to stats.Handler.HandleRPC() #2692

Closed
jDamgaard opened this issue Mar 15, 2019 · 0 comments · Fixed by #2711 or #2932
Closed

WireLength is not set on the stats.InPayload used as input to stats.Handler.HandleRPC() #2692

jDamgaard opened this issue Mar 15, 2019 · 0 comments · Fixed by #2711 or #2932

Comments

@jDamgaard
Copy link

Since this commit (part of the v1.17.0 release), the WireLength field on the stats.InPayLoad struct that is passed to stats.Handler.HandleRPC() is no longer set.

The InPayload struct still contains the WireLength field, and the comments indicates it is expected to be set.
The field used to be populated on the inPayload struct passed to recv in stream.go, but that struct is no longer the one returned, and the field is not populated on the struct that is returned link to code
@ilylia ilylia mentioned this issue Mar 22, 2019
Merged
menghanl pushed a commit that referenced this issue Mar 25, 2019
@ilylia @menghanl
stats: add WireLength to stats.InPayload (#2692) (#2711)
ed10349
@ajwerner ajwerner mentioned this issue Jul 23, 2019
Merged
ajwerner added a commit to ajwerner/grpc-go that referenced this issue Jul 24, 2019
@ajwerner
server: populate WireLength on stats.InPayload for unary RPCs
de0849b 
Fixes grpc#2692 which was incompletely fixed by grpc#2711.

Also adds a basic unit test which provides scaffolding for further testing of
the stats logic.
@ajwerner ajwerner mentioned this issue Jul 24, 2019
Merged
ajwerner added a commit to ajwerner/grpc-go that referenced this issue Jul 24, 2019
@ajwerner
server: populate WireLength on stats.InPayload for unary RPCs
1a729ca 
Fixes grpc#2692 which was incompletely fixed by grpc#2711.

Also adds a basic unit test which provides scaffolding for further testing of
the stats logic.
ajwerner added a commit to ajwerner/grpc-go that referenced this issue Jul 24, 2019
@ajwerner
server: populate WireLength on stats.InPayload for unary RPCs
3e986df 
Fixes grpc#2692 which was incompletely fixed by grpc#2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
menghanl pushed a commit that referenced this issue Jul 24, 2019
@ajwerner @menghanl
server: populate WireLength on stats.InPayload for unary RPCs (#2932)
b5748ca 
Fixes #2692 which was incompletely fixed by #2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
ajwerner added a commit to ajwerner/grpc-go that referenced this issue Jul 25, 2019
@ajwerner
server: populate WireLength on stats.InPayload for unary RPCs (grpc#2932
359d7c2 
)

Fixes grpc#2692 which was incompletely fixed by grpc#2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
menghanl pushed a commit that referenced this issue Jul 25, 2019
@ajwerner @menghanl
server: populate WireLength on stats.InPayload for unary RPCs (#2932)
d95b9a7 
Fixes #2692 which was incompletely fixed by #2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
menghanl pushed a commit that referenced this issue Jul 25, 2019
@ajwerner @menghanl
server: populate WireLength on stats.InPayload for unary RPCs (#2932)
f0893a5 
Fixes #2692 which was incompletely fixed by #2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
@lock lock bot locked as resolved and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jDamgaard