Detect native HttpHandler on Android #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
halter73,
captainsafia,
BrennanConroy and
brunolins16
gfoidl
reviewed
Oct 27, 2022
| { | ||
| // Validate the user specified handler is compatible with this platform. | ||
| // | ||
| // Android's native handler doesn't fully support HTTP/2 and using it could cause hard to understand errors |
There was a problem hiding this comment.
Does this mean the native handler works for some cases? And what if the native handler improves in the future to have better support? Should there be a switch to ignore this check and allow using the native handler?
There was a problem hiding this comment.
My thought is if that happens, the grpc-dotnet client can be updated to detect the Android OS version that fully supports gRPC, and not throw this error.
BrennanConroy
approved these changes
Oct 31, 2022
JamesNK
force-pushed
the
jamesnk/android-validate-handler
branch
from
b735e5d to
8b9a895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android uses a native HTTP handler if
HttpClientHandleris specified. The native HTTP handler doesn't have enough HTTP/2 support for gRPC and can cause errors. Example: #1923. We want Android to always useSocketsHttpHandler.Detect if a native HttpHandler is being used on Android, and throw a friendly error message on Android if necessary.
Doc at https://aka.ms/aspnet/grpc/android will be added soon.