Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot compile with GOARCH=386 due to integer overflow #752

Closed
fesiqueira opened this issue Feb 25, 2025 · 1 comment
Closed

Cannot compile with GOARCH=386 due to integer overflow #752

fesiqueira opened this issue Feb 25, 2025 · 1 comment

Comments

@fesiqueira
Copy link
Contributor

Hi!

The latest release (v2.3.0) can't be compiled with GOARCH=386 due to changes introduced by #747.

The error message is:

go-grpc-middleware/[email protected]/interceptors/retry/backoff.go:35:10: cannot use 1 << 62 (untyped int constant 4611686018427387904) as uint value in return statement (overflows)

I'd like to work on a fix for it, if this is relevant, of course.
@johanbrandhorst
Copy link
Collaborator

Hi, thanks for your issue. Please do contribute a PR if you can.

fesiqueira added a commit to fesiqueira/go-grpc-middleware that referenced this issue Feb 26, 2025
@fesiqueira
Return uint64 from exponentBase2 function
9fa8a07 
A 32bit binary could not be built because `1 << 62` would overflow the
return `uint` type, as it is an architecture dependent type.

Closes grpc-ecosystem#752
@macabu macabu mentioned this issue Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johanbrandhorst @fesiqueira