Add new social icons #322
Merged
Add new social icons #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halocline
approved these changes
Aug 31, 2023
This was referenced Sep 13, 2023
This was referenced Oct 9, 2023
|
Discord icon is still missing, although per #126 (it is closed) it seems it has been added. |
|
@withpublic Apologies, Discord icon has not been added and it was incorrectly closed. I'll reopen the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new social/brand icons.
fillis appropriate to use on social/brand icons as opposed tostrokebecause the scaling/proportions needs to remain intact.Tested in storybook locally and applied
color="plain"andcolor="attention"(local storybook theme color) to make sure icons rendered as expected.Related to #321
Closes #221 #188 #126