added info returning info map. made object.Array sortable replacing MapKeys, use Equals in constant check, fix missing FLOAT handling
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MapKeys, use Equals in constant check, fix missing FLOAT handling
ccoVeille
reviewed
Aug 5, 2024
…ore, conversion through NativeBoolToBooleanObject only where needed
ccoVeille
reviewed
Aug 5, 2024
ldemailly
commented
Aug 5, 2024
| @@ -671,9 +671,9 @@ func evalMapInfixExpression(operator token.Type, left, right object.Object) obje | |||
| rightMap := right.(object.Map) | |||
| switch operator { //nolint:exhaustive // we have default. | |||
| case token.EQ: | |||
| return object.MapEquals(leftMap, rightMap) | |||
| return object.NativeBoolToBooleanObject(object.MapEquals(leftMap, rightMap)) | |||
There was a problem hiding this comment.
I had already marked the file as read, so when I saw the refactoring I thought it was no longer used
There was a problem hiding this comment.
np and btw thanks a lot for all your time reviewing all these PRs
ccoVeille
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inforeturning info map including identifiers stack (see README.md update for examples) and:booluntil last minuteExample: