Skip to content

Commit

Permalink
Remove redundant ShouldForwardFromEditToCombo() check
Browse files Browse the repository at this point in the history
No real changes, just avoid calling ShouldForwardFromEditToCombo() in
MSWProcessEditMsg() because this function is only called when the
message should be forwarded.

Also make the comment about the return value more clear.
  • Loading branch information
vadz committed Feb 17, 2018
1 parent 0d640f8 commit 6bb4575
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions src/msw/combobox.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -277,15 +277,10 @@ bool wxComboBox::MSWProcessEditMsg(WXUINT msg, WXWPARAM wParam, WXLPARAM lParam)
break;
}

if ( ShouldForwardFromEditToCombo(msg) )
{
// For all the messages forward from the edit control the
// result is not used.
WXLRESULT result;
return MSWHandleMessage(&result, msg, wParam, lParam);
}

return false;
// For all the messages forwarded from the edit control the result is not
// used and 0 must be returned if the message is handled.
WXLRESULT result;
return MSWHandleMessage(&result, msg, wParam, lParam);
}

bool wxComboBox::MSWCommand(WXUINT param, WXWORD id)
Expand Down

0 comments on commit 6bb4575

Please sign in to comment.