Fix output file bug in image generation tool/task #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfrench
changed the title
collindutter
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image generation task and tool accept
output_fileconfigurations which specify where on the filesystem to store the generated image. This field can include a directory prefix likeimages/image.png, in which case./images/will be created if necessary. In the case where no directory prefix is provided, likeimage.png, the file should be placed in the current directory. Instead, the tool/task attempted to create a parent directory with empty name"", causing an exception. This updates the code paths to include a check, ignoring empty requests to mkdirs.