Export API Symbols for MSVC #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
requested changes
Jul 11, 2022
There was a problem hiding this comment.
Can we generate this file in some way automatically? We already have “redundant” definitions of the C API in include/xtb.h and src/api/*.f90. Having another file which must be kept up to date makes it more error prone, especially if we are not checking the correctness in the CI.
|
In terms of automatic generating the def/exporting symbols, it seems like meson can't do this: mesonbuild/meson#2132 I'll work on seeing if I can get a dllexport/dllimport version working instead of making the .def file. |
awvwgk
reviewed
Jul 12, 2022
awvwgk
reviewed
Jul 12, 2022
By default, the Visual Studio C compiler doesn't export any symbols, so xtb.lib wasn't being created. Explicitly export C API functions using dllexport attribute. Signed-off-by: Ty <[email protected]>
awvwgk
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so xtb.lib wasn't being created. Adding a def file of functions exported
and pointing to it in meson.build allows it create xtb.lib.
This should close #646