Update OpenMP parallelization in WSC to avoid data-races #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxtran
changed the title
foxtran
force-pushed
the
fix/datarace-wsc
branch
3 times, most recently
from
70cf3a7 to
c1ef291
Compare
|
Just made a small update to make allocation in parallel region for avoiding OMP stack usage. |
|
It fixes random failures of |
foxtran
force-pushed
the
fix/datarace-wsc
branch
from
c1ef291 to
ca4d2c6
Compare
|
Can you also remove the unused |
Signed-off-by: Igor S. Gerasimov <[email protected]>
This reverts commit 85e659b. Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
foxtran
force-pushed
the
fix/datarace-wsc
branch
from
ca4d2c6 to
5145905
Compare
Signed-off-by: Igor S. Gerasimov <[email protected]>
|
@marvinfriede, I have updated the code with your suggestions |
marvinfriede
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed data-races from shared minpos/mindist/nminloc/nmindist. Now,
wscandpeeqtests should be repeatable.