Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only write groups in Turbomole output if necessary #41

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Apr 14, 2022

For compatibility with less flexible Turbomole readers.

  • write in decimal format by default, switch to scientific notation for large numbers
  • don't write the $eht group in case the system is uncharged or has no unpaired electrons
  • only write $periodic group for if there is at least one periodic dimension

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #41 (209a885) into main (3d0e921) will decrease coverage by 0.07%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   69.88%   69.80%   -0.08%     
==========================================
  Files          60       60              
  Lines        7610     7615       +5     
  Branches     2227     2232       +5     
==========================================
- Hits         5318     5316       -2     
- Misses        735      738       +3     
- Partials     1557     1561       +4     
Impacted Files Coverage Δ
src/mctc/io/write/turbomole.f90 47.36% <11.11%> (-31.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0e921...209a885. Read the comment docs.

@awvwgk awvwgk merged commit d2411d9 into grimme-lab:main Apr 14, 2022
@awvwgk awvwgk deleted the tmol branch April 14, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant