Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading of v3000 connection tables #34

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Feb 26, 2022

Closes #32

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #34 (37cb0d0) into main (5db20f9) will increase coverage by 1.83%.
The diff coverage is 84.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   68.18%   70.02%   +1.83%     
==========================================
  Files          56       56              
  Lines        6405     7215     +810     
  Branches     1961     2105     +144     
==========================================
+ Hits         4367     5052     +685     
- Misses        671      685      +14     
- Partials     1367     1478     +111     
Impacted Files Coverage Δ
src/mctc/io/read/ctfile.f90 61.80% <54.11%> (-11.43%) ⬇️
test/test_read_ctfile.f90 90.20% <92.46%> (+2.58%) ⬆️
src/mctc/io/write/pdb.f90 25.00% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db20f9...37cb0d0. Read the comment docs.

@awvwgk awvwgk merged commit 7d40997 into grimme-lab:main Feb 26, 2022
@awvwgk awvwgk deleted the ctab-v3k branch February 26, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ctfiles with V3000 formatted connection table
1 participant