Fix inconsistencies in ORCA interface
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Müller <[email protected]>
marcelmbn
requested review from
jonathan-schoeps and
lmseidler
as code owners
jonathan-schoeps
previously approved these changes
Feb 17, 2025
Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Marcel Müller <[email protected]>
|
If you could look again into this one, this would be great! @jonathan-schoeps |
jonathan-schoeps
previously approved these changes
Feb 17, 2025
Signed-off-by: Marcel Müller <[email protected]>
|
Noticed bugs with this, without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opt_cyclescan currently not be left out as it's always initialized with an integer and declaringNoneis not a viable option. Fixed.NoSOSCFdoesn't make sense in ORCA6.0.1, we should take the default instead.SlowConvshould only be added in specific cases (see issue Add option to read in simple keywords for ORCA #124)mediumfor geometry optimizations.