GSYE-775: Use price settings of loads and pvs for the FIT and MMR in … #1840
Conversation
…the homes when running in non-P2P mode
| energy_sell_rate = self._energy_sell_rate if mmr is None else mmr | ||
| energy_buy_rate = self._energy_buy_rate if fit is None else fit |
There was a problem hiding this comment.
The mmr and fit will never be None, because of the default values of the strategies.
So, this if statement does not have an effect and the user can not globally change the MMR and FIT via the one market maker. They have to individually change the rates in the strategies.
I wonder if this is a good approach or wether we should add some setting/flag that toggles using the global market maker or not.
What do you think @spyrostz ?
There was a problem hiding this comment.
Hmm , this I need to check, because if I recall correctly these strategy parameters are overridden if a global market maker rate is set. Editing the comment in a bit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1840 +/- ##
==========================================
+ Coverage 69.55% 69.70% +0.14%
==========================================
Files 150 150
Lines 14283 14298 +15
Branches 2678 2680 +2
==========================================
+ Hits 9935 9966 +31
+ Misses 3822 3808 -14
+ Partials 526 524 -2 🚀 New features to boost your workflow:
|
…the homes when running in non-P2P mode
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master