Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSYE-845: Add scripts and readme for training teknikers COP model #1834

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

hannesdiedrich
Copy link
Member

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.68%. Comparing base (c4ee97a) to head (bbb77e1).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1834      +/-   ##
==========================================
+ Coverage   69.63%   69.68%   +0.04%     
==========================================
  Files         150      150              
  Lines       14258    14258              
  Branches     2672     2672              
==========================================
+ Hits         9928     9935       +7     
+ Misses       3805     3798       -7     
  Partials      525      525              

@@ -0,0 +1,67 @@
# Individual COP model integration

This document describes to train COP models, developed by [Tekniker](https://www.tekniker.es/en/) by deploying the [DOE-2](https://www.doe2.com/) building energy analysis program, to yield a statistical model by leveraging measurements of select heat pump manufacturers under predefined operational conditions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This document describes to train COP models, developed by [Tekniker](https://www.tekniker.es/en/) by deploying the [DOE-2](https://www.doe2.com/) building energy analysis program, to yield a statistical model by leveraging measurements of select heat pump manufacturers under predefined operational conditions.
This document describes how COP of arbitrary heat pump models can be modelled and integrated. The COP model used is developed by [Tekniker](https://www.tekniker.es/en/) by deploying the [DOE-2](https://www.doe2.com/) building energy analysis program. The program yields a statistical model by leveraging measurements of select heat pump manufacturers under predefined operational conditions.

Comment on lines 7 to 8
The goal of training the COP model is to produce a JSON file that contains the COP model parameters for a specific heat pump.
For training the COP model, performance data for the selected heat pump is needed, that comply to the characteristics listed in the following section.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The goal of training the COP model is to produce a JSON file that contains the COP model parameters for a specific heat pump.
For training the COP model, performance data for the selected heat pump is needed, that comply to the characteristics listed in the following section.
The training of the COP model produces a JSON file that contains the COP model parameters for a specific heat pump. This will later be used by the HeatPumpStrategy model, in order to more accurately approximate the select heat pump model.
For training the COP model, performance data for the selected heat pump is needed, that comply to the characteristics listed in the following section.

Comment on lines 13 to 16
A table of heat production (Q) in kW as a function of air temperature and condensor temperature needs to be provided for the full load operation of the heat pump.
The temperature range that is provided, is the range that the COP model will produce valid data.
Consequently, a large range and a high resolution of input data will result in more realistic output values.
In the following, an example table is shown.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A table of heat production (Q) in kW as a function of air temperature and condensor temperature needs to be provided for the full load operation of the heat pump.
The temperature range that is provided, is the range that the COP model will produce valid data.
Consequently, a large range and a high resolution of input data will result in more realistic output values.
In the following, an example table is shown.
A table of heat production (Q) in kW needs to be provided for the full load operation of the heat pump. The heat production is represented as a function of air temperature and condenser temperature.
The COP model will produce valid data only for the provided temperature range.
Consequently, a large range and a high resolution of input data will result in more realistic output values.
In the following, an example table is shown.

Comment on lines 13 to 16
A table of heat production (Q) in kW as a function of air temperature and condensor temperature needs to be provided for the full load operation of the heat pump.
The temperature range that is provided, is the range that the COP model will produce valid data.
Consequently, a large range and a high resolution of input data will result in more realistic output values.
In the following, an example table is shown.
Copy link
Member

@spyrostz spyrostz Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move the sentence:

In the following, an example table is shown.

to the legend of the table, named "Example heat production table"


The partial load data represents the full range of load to be simulated by the model.
A combination of Q and P for different loads of the heat pump needs tp be provided in table form.
There must be a minimum of three distinct part-load data points for the same temperature conbination.
Copy link
Member

@spyrostz spyrostz Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There must be a minimum of three distinct part-load data points for the same temperature conbination.
There must be a minimum of three distinct partial-load data points for the same temperature combination.

Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, most are minor syntax / grammar corrections which are not important for the operation of the feature. Thanks!

@hannesdiedrich hannesdiedrich merged commit 66d1812 into master Jan 23, 2025
4 checks passed
@hannesdiedrich hannesdiedrich deleted the feature/GSYE-845 branch January 23, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants