Feature/gsye 836 #1828
Merged
Feature/gsye 836 #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1828 +/- ##
==========================================
- Coverage 69.67% 69.63% -0.05%
==========================================
Files 150 150
Lines 14255 14258 +3
Branches 2670 2672 +2
==========================================
- Hits 9932 9928 -4
- Misses 3798 3805 +7
Partials 525 525 |
spyrostz
reviewed
Jan 20, 2025
| @@ -91,6 +91,14 @@ def last_past_market(self): | |||
| except IndexError: | |||
| return None | |||
|
|
|||
| # def is_market_future(self, market_id: str) -> bool: | |||
spyrostz
previously approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master