GSYE-568: Add create_hierarchy_stats to SimulationEndpointBuffer #1796
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1796 +/- ##
=======================================
Coverage 69.51% 69.51%
=======================================
Files 147 147
Lines 13943 13986 +43
Branches 2598 2607 +9
=======================================
+ Hits 9692 9722 +30
- Misses 3742 3753 +11
- Partials 509 511 +2 |
There was a problem hiding this comment.
Looks Good!
On another note, I noticed now that we are using variables with "scm" attached in gsy-e too. I believe we have extensively used this in order to identify logic that is probably only used in our SCM product. But in the case of gsy-e which is open-source code IMO it should be totally avoided and removed.
| """Calculate hierarchy related statistics.""" | ||
| hierarchy_self_consumption_list = {} | ||
| self._calc_hierarchy_stats(area, 0, hierarchy_self_consumption_list) | ||
| for level, consumption_list in hierarchy_self_consumption_list.items(): |
There was a problem hiding this comment.
The KPI value is not the intended one here. We actually want to replicate this:
Therefore I think that this can be done a bit more elaborate here. Let's discuss it on Slack to settle. I will also add the screenshot in the ticket in order to have it available.
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master