GSYE-767: Enable passing profiles to OrderUpdaterParameters #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigTava
approved these changes
Sep 18, 2024
| return self.update_interval | ||
|
|
||
| @staticmethod | ||
| def _get_default_value_initial_rate(_time_slot: DateTime): |
There was a problem hiding this comment.
Hmmm, it feels we can simplify here no and just return 0 instead of calling this function? Or the idea is to have a default value for every time_slot?
There was a problem hiding this comment.
Please have a look at the HeatPumpOrderUpdaterParameters that inherits from the OrderUpdaterParameters. This is to inject a different default value to every implementation of OrderUpdaterParameters. Here we do not need a specific default value. Does it make sense?
There was a problem hiding this comment.
I see we are overriding the function. Looks fine then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master