Remove Bisq #151
Merged
Remove Bisq #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barton2526
reviewed
Feb 26, 2019
source/layouts/partials/_header.erb
Outdated
| @@ -80,10 +80,6 @@ | |||
| </a> | |||
| <div class="dropdown-menu" aria-labelledby="navbarDropdown"> | |||
| <a class="dropdown-header">Exchanges</a> | |||
| <!-- | |||
| <a class="dropdown-item" href="https://bitshares.openledger.info/#/market/OPEN.GRC_OPEN.BTC"><i class="fa fa-exchange"></i> OpenLedger</a> | |||
There was a problem hiding this comment.
Can we keep this part commented out? It is feasible that OpenLedger will be usable again if they ever fix their gateway.
|
@ShmoogleOsukami Can we also remove the image assets? https://github.com/gridcoin-community/Gridcoin-Site/blob/master/source/assets/img/Exchanges/bisq.png |
barton2526
reviewed
Feb 26, 2019
source/layouts/partials/_header.erb
Outdated
| <!-- | ||
| <a class="dropdown-item" href="https://bitshares.openledger.info/#/market/OPEN.GRC_OPEN.BTC"><i class="fa fa-exchange"></i> OpenLedger</a> | ||
| --> | ||
| <a class="dropdown-item" href="https://bisq.network/">bisq</a> |
There was a problem hiding this comment.
still need to remove this line (86)
|
Think I got everything this time. :D |
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removed Bisq from the website.
As far as I know it was in 3 locations, the header, footer and _acquire_details.