Add research subsidy to overview page.

[tomasbrod]

Status: again broken (low priority)
No longer a follow up of #301.
My UI modification is not nice, but it works. @skcin how can I setup so we can cooperate?

The ResearchSubsidy is the amount one would receive for research (excluding interest and fees) if he were to stake at that moment.

[iFoggz]

Curious:

How did you get that ResearchSubsidy includes the interest and fees (+interest +fee as you've said) ?

My assumption was It was ResearchSubsidy + InterestSubsidy is the Mint on top of staked coins?

Correct me if I'm wrong:)

Btw good work. Also couldn't we just say Est Owed instead of ResearchSubsidy on UI?. Est Oeed because it will change when magntide unit changes. May look neater:) cheers.

For example

https://github.com/gridcoin/Gridcoin-Research/blob/a8442f7bbdfa16e81a99db396e01db091aa6889e/src/miner.cpp#L484
https://github.com/gridcoin/Gridcoin-Research/blob/a8442f7bbdfa16e81a99db396e01db091aa6889e/src/miner.cpp#L485

[ghost]

Great addition to the wallet.

Would it be possible to make it like Gridcoin Stats and have two entries:

• Est Research Owed
• Est Interest Owed

[iFoggz]

@3ullShark Interest owed is not a bad idea but a user might get confused if they make a transaction and the interest owed drops. When you move sets of coins to another address within your wallet or a change address u won't get the previous interest owed on those coins. This is something I have noticed on my end of things as I'm a little too organized and also ran an experiment having a single coin block of all coins versus multiple addresses in my wallet with large blocks.

Off topic:
My findings on that research is its better to have more coin blocks for staking versus one big one. I'm staking more often that way.

However I would support doing a "Est Research Owed" and "Est Interest Owed". As I've posted above Total subsidy = ResarchSubsidy + InterestSubsidy least from what I see in the code so shouldn't be hard to do.

[tomasbrod]

The interest subsidy is calculated wrong in my code. Interest owed is for each coin (UTXO) different. It will be harder to calculate properly.

How did you get that ResearchSubsidy includes the interest and fees (+interest +fee as you've said)? My assumption was It was ResearchSubsidy + InterestSubsidy is the Mint on top of staked coins?

Not clear enough am I. Your next reward is block transaction fees + interest for coins that form the stake kernel + research reward for cpid. ResearchSubsidy only includes research rewards not the fees and interest.

It is unknown what outstanding transaction will be at time of stake therefore txfees can't be shown. It is unknown what coins are going to stake, so interest can't be shown. What could be shown is sum of interest on all coins (UTXOs), but that must wait for stake-miner-code refactoring.

My findings on that research is its better to have more coin blocks for staking versus one big one. I'm staking more often that way.

Besides the fact that coins must mature 16 hours, there is a bug here related to magnitude that has this effect, but not yet confirmed.

[iFoggz]

@tomasbrod We could still do "Est Owed Research" and do the same calculation as the code does for ResearchSubsidy. If future changes occur in code for mag, etc it can be changed at anytime when or if changes occur. I watch what i'm owed in debug at the moment but would rather it on UI instead of doing cat debug.log | grep createnewblock which lists example

Example: (done when ComputeResarchAccrual is called) main.cpp#L10014

2017-05-14 21:54:35 Operation createnewblock, ComputedAccrual 51.569167, StakeHeight 898754.000000, RABlockSpan 555.000000, HistoryHeight898199.000000, AccrualAge 0.603148, AvgMag 380.000000, MagUnit 0.225000, PPD 48.588347, Reference PPD 31.035221

And thanks for the bug info I will check that out :)

[skcin]

@tomasbrod nice, I think it is a good idea to add these values to the gui. But I am not convinced that all these values should be displayed on the overview page. I was thinking about adding an additional page just for displaying all these informations and statistics. What do you think about that?

Maybe you can rename ResearchSubsidy to something more intuitive?

The PPD and Fulf % previously shown on the overviewpage are calculated in rpcblockchain.cpp lines 3648-3711. There are several other values calculated for the RSA report. What do you think of using those values?

[tomasbrod]

@skcin, The RSA PPD values are no longer used to calculate rewards. Yes, i would like to rename the field, but I don't know good name for it. I am for separate page with more details that is good idea. We need to decide what info to be displayed on overview. And I am not skilled with gui.

In my opinion the following items are not important to be shown on overview page. Let's discuss.

• project
• difficulty or net weight (one of them)
• Stake (add to unconfirmed)
• And some of the number fields could be placed on the same row, in 2 columns.
• GRC Magnitude Unit
• CPID

[iFoggz]

I would be opposed to removal of all fields essentially. I'm on the fence regarding the project one. The network weight and difficulty shows the health of the network. Visual before technical. mag unit is important information as it shows the coin production on the network in general as it goes down when too many coins are produced and up when not enough are produced. If you have Research Subsidy owed showing and all of a sudden it drops and your mag is unchanged it can cause confusion if the mag unit is not showing why.

Are you talking about renaming PPD fields on UI?

As for PPD values in ui I could understand them not being listed on the ui but they will remain in code and would be availible in console/rpc. Yes they are not used for calculation of rewards but its information even I review in console/rpc but not on ui. As for renaming them I'm not opposed to that. PPD is really only used in ComputeResearchAccrual to prevent an insane payment as my understanding of it. if PPD > Reference PPD * 5 sets Accural=0 and once things in future are within bounds it would they pay out what is owed. So ya i agree there is room for play on the PPD part on ui.

Fulfillment is another field that isn't needed as its really just based in the time period of the rsa and has no impact on payments. ComputeResearchAccrual keeps track of whats owed base on code and just because u stake a bunch of blocks in the time frame of rsa it can say over 100% but not necessarily overpaid.

A second page would take work to not make it so bare. It would be kinda pointless to have a second page with just a couple values. I'd like Network Weight, Difficulty, Stake, CPID, mag unit, Research Subsidy, blocks and DPOR weight(not opposed to name changing this, could be Coin Weight or Stake Weight), and magnitude to be on the main ui screen. Act PPD, Exp PPD, fulfillment I'm not to concerned with being on the ui and I don't think we need it on the main ui.

Just my 2 cents.

[tomasbrod]

I would be opposed to removal of all fields essentially.
A second page would take work to not make it so bare. It would be kinda pointless to have a second page with just a couple values.

I don't want to remove them either. Just move to second page. The overview is already crowded. The plus is that various other numbers could be added to the second page and no compromises would have to be made.

I'm on the fence regarding the project one.

Project name is no longer used in staking code. It is not even included in hashboinc.

The network weight and difficulty shows the health of the network.

Network weight is derived from difficulty. So why two fields for one thing? Net weight is hard to read for me without a thousand separator. What about adding suffix k, M, G, mil, bil? Ex: 60137352.21 -> 60M or 60'137'352.21 or 60 mil.

As for PPD values in ui I could understand them not being listed on the ui,

Yes. The ExpPPD is not used to calculate reward. Except for the check of insane reward you mentioned. Even the ActPPD becomes zero after 14 days. I don't see information value in these, that's it. I am not talking about removing them from RPC.

ComputeResearchAccrual keeps track of whats owed base on code and just because u stake a bunch of blocks in the time frame of rsa it can say over 100% but not necessarily overpaid.

Idk if we are looking at the same function, but once someone gets dpor reward, all past owed amounts are forgotten. Only when iRABlockSpan > 20 DAYS the magnitude is averaged over greater period.

I'd like Network Weight, Difficulty, Stake, CPID, mag unit, Research Subsidy, blocks and DPOR weight(not opposed to name changing this, could be Coin Weight or Stake Weight), and magnitude to be on the main ui screen. Act PPD, Exp PPD, fulfillment I'm not to concerned with being on the ui and I don't think we need it on the main ui.

I don't see Est Owed Research on your list, you don't want it in overview?
DPOR weight -> "Your weight"?

[iFoggz]

I would want to see the concept of which you speak of then maybe i'll get a better feel for it as well as others could too if they see a full picture of wallet with the changes you wish to put forth. :) but I don't agree its crowded since the new ui changes have been done it looks a lot more cleaner and not nearly as crowded as before. But I agree an item or a few could go or be moved. But I remember sometime before during the ui stuff that I think people were against an extra tab. I could be wrong its been awhile since that discussion.

On a second tab or something you could do the boinc information like project, cpid, but id want to keep all base network information and owed on the main ui.

Thousand separator is something I'd agree with like 1,234,567.00 but I'm not opposed to 1.234M, If you did shorten I'd like 3 decimal places. personal preference again.

And in the ComputeResearchAccrual i was talking about https://github.com/gridcoin/Gridcoin-Research/blob/1ddf6b897613bcb745414eef109f512f496dacc2/src/main.cpp#L10089
it was just reference to the PPD, etc nothing of huge importance :)

As for "Est Owed Research" should of been in place of ResearchSubsidy but its basically the same.
DPoR Weight could be Your Coin Weight or Stake Weight or anything that normal users could understand better.

Id like it if other people would chime in as it seems like a lack of community involvement so far. We need consensus on what others think about this as well when it comes to ui.

but good work and bringing forward ideas.

[skcin]

To get this conversation forward I added a statistics page and moved some of the values over. Take a look and discuss ;)

@tomasbrod I pushed it to your repo since you gave me access, hope thats ok

[denravonska]

@skcin Do you have a screenshot of it? Maybe we can move some of the NN stuff, like bandwidth, to that page instead?

[tomasbrod]

Looks good @skcin. It is obviously not finished. I definitely like that some info from overview is also present on advanced. It is OK to push to my repo. Can you include few comments in the source on how to add fields to that page, please?

Now we have to choose what is important enough to stay on overview. And what extra data to show on advanced tab. Something from the debug window? Or move the stats to the debug window.
What kind of NN stuff you have in mind @denravonska?

The reason for advanced info page is that we, developers, can put anything that we find interesting there without worrying about taking too much space or confusing users. Once it gets popular enough we can include it in overview.

Here come the screenshots.

[skcin]

oh, @tomasbrod was faster :). I agree, the statistics page should be used by advanced users and for trouble shooting. If everything works as expected there is no need to bother users with all that information. I think what we are missing on the overview page is some value showing the expected earnings, a reliable value of how hard it is to stake (maybe the probability to stake or the expected time) and an indicator if the wallet is up to date. But I think right now these don't exist.

Everything on the overview page should be easy to understand.

@denravonska I think there is plenty of room on the statistics page for additional information.

[iFoggz]

@skcin Looks nice guys, PoC always is best. I agree with the way it looks and with room to add more values in statistics is excellent! Nice work. I believe the community will take more to the changes if they see them before hand in the development process :)

[denravonska]

What's the status of this? Do we include it in the next release?

[tomasbrod]

If you want to @denravonska. It works, it is not harmful. But still not complete.

[skcin]

@denravonska I don't know if the statistics page works on windows. The overview page has some additional includes for windows:
#ifdef WIN32 #include <QAxObject> #include "../global_objects.hpp" #include "../global_objects_noui.hpp" #endif

Is that needed? I have not added these lines in the statistics page.

[denravonska]

@skcin The QAxObject should only be needed if you're calling .NET code from C++. The others are just to access some globals, I assume.

[tomasbrod]

I accidentally broke compatibility with this in my latest commits.
Will be restored.

[denravonska]

Also, change it to Research Subsidy: and we should be good to go.

[tomasbrod]

Rebased on top of current dev. Compiles, but still broken (owed is blank in gui).
The reward is now calculated only when block is staked so I can't hook to miner to display the info. I think I'll move the calculation main thread.

[tomasbrod]

Now it correctly shows the amount owed.
changed status broken->usable.

[tomasbrod]

This change-set was again broken by upstream changes. And #562 somewhat intersects with this.

[tomasbrod]

This issue went stale. Closing.