Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated RSA weight and legacy kernel #1507

Merged

Conversation

cyrossignol
Copy link
Member

@cyrossignol cyrossignol commented Jul 30, 2019

This cleans up the staking kernel by removing the old algorithms for version 7 blocks and earlier. It removes the deprecated RSA weight parameter and provides a mechanism to carry proof hashes of version 7 blocks into version 8 to facilitate the calculation of the stake modifier for the current staking kernel routine.

@jamescowens jamescowens added this to the Elizabeth milestone Jul 30, 2019
@jamescowens
Copy link
Member

This seems to pair with #1497 as clean up for the mandatory.

@jamescowens jamescowens modified the milestones: Elizabeth, Fern Aug 8, 2019
@cyrossignol cyrossignol marked this pull request as ready for review August 11, 2019 18:16
@cyrossignol
Copy link
Member Author

Sync has been tested on testnet and on mainnet by @denravonska.

Copy link
Member

@jamescowens jamescowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good to me.

@jamescowens
Copy link
Member

Give the importance of these changes. I have assigned @denravonska to second review. My guess is that it is a formality, given that @denravonska has synced from zero as a test already (implies he is happy with it).

@jamescowens
Copy link
Member

Once this is merged, development will branch away from staging... This is post-Elizabeth stuff...

@jamescowens
Copy link
Member

@denravonska will you sign off on this and then we can merge into development.

@denravonska denravonska merged commit b2ac952 into gridcoin-community:development Aug 19, 2019
@cyrossignol cyrossignol deleted the remove-rsa-weight branch August 19, 2019 16:24
jamescowens added a commit that referenced this pull request Oct 22, 2019
Added
 - Add testnet desktop launcher action for Linux #1516 (@caraka)
 - Shuffle vSideStakeAlloc if necessary to support sidestaking to more than 6 destinations #1532 (@jamescowens)
 - New Superblock format preparations for Fern #1526, #1542 (@jamescowens, @cyrossignol)
 - Multisigtools
   - Consolidate multisig unspent #1529 (@iFoggz)
   - Scanforunspent #1547 (@iFoggz)
   - consolidatemsunspent and scanforunspent bug fix #1561 (@iFoggz)
 - New banning misbehavior handling and Peers Tab on Debug Console #1537 (@jamescowens)
 - Reimplement getunconfirmedbalance rpc #1548 (@jamescowens)
 - Add CLI switch to display binary version #1553 (@cyrossignol)

Changed
 - Select smallest coins for contracts #1519 (@iFoggz)
 - Move some functionality from miner to SelectCoinsForStaking + Respect the coin reserve setting + Randomize UTXO order #1525 (@iFoggz)
 - For voting - if url does not contain http then add it #1531 (@iFoggz)
 - Backport newer serialization facilities from Bitcoin #1535 (@cyrossignol)
 - Refactor ThreadSocketHandler2() Inactivity checks #1538 (@iFoggz)
 - Update outdated checkpoints #1539 (@barton2526)
 - Change needed to build Gridcoin for OSX using homebrew #1540 (@Git-Jiro)
 - Optimize scraper traffic for expiring manifests #1542 (@jamescowens)
 - Move legacy neural vote warnings to debug log level #1560 (@cyrossignol)
 - Change banlist save interval to 5 minutes #1564 (@jamescowens)
 - Change default rpcconsole.ui window size to better support new Peers tab #1566 (@jamescowens)

Removed
 - Remove deprecated RSA weight and legacy kernel #1507 (@cyrossignol)

Fixed
 - Clean up compiler warnings #1521 (@cyrossignol)
 - Handle missing external CPID in client_state.xml #1530 (@cyrossignol)
 - Support boost 1.70+ #1533 (@iFoggz)
 - Fix diagnostics failed to make connection to NTP server #1545 (@Git-Jiro)
 - Install manpages in correct system location #1546 (@Git-Jiro)
 - Fix ability to show help and version without a config file #1553 (@cyrossignol)
 - Refactor QT UI variable names to be more consistent, Fix Difficulty default #1563 (@barton2526)
 - Fix two regressions in previous UI refactor #1565 (@barton2526)
 - Fix "Owed" amount in output of "magnitude" RPC method #1569 (@cyrossignol)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants