5.2.0.0, 2021-03-01, mandatory, "Hilda"

Added - gui: Add RAC column to wizard summary page projects table #1951 (@cyrossignol) - rpc: clean up the superblocks function and add magnitude to getmininginfo #1966 (@jamescowens) - rpc: Add transaction size to RPC output #1971 (@cyrossignol) - voting: Add user-facing support for poll response types #1976 (@cyrossignol) - gui: Port Bitcoin Intro class (implement the ability to choose a data directory via the GUI) #1978 (@jamescowens) - gui: Port Bitcoin MacOS app nap manager #1991 (@jamescowens) - mining, rpc: Implement staking efficiency measure and improve SelectCoinsForStaking and CreateCoinStake #1992 (@jamescowens) - accrual, rpc: Implement auditsnapshotaccruals #2001 (@jamescowens) - docs: add doxygen support #2000 (@div72) - beacon: Specialized beacon storage in leveldb #2009 (@jamescowens) - rpc: Add a call to dump contracts in binary form #2011 (@div72) - rpc: Add boolean option to report active beacons only in beaconreport #2013 (@jamescowens) - consensus: Set Hilda mainnet hardfork height to 2197000 #2022 (@jamescowens) Changed - refactor: [Memory optimization] Block index duplicate PoS state #1945 (@cyrossignol) - refactor: [Memory optimization] Block index superblock and contract flags #1950 (@cyrossignol) - refactor: [Memory optimization] Remove stake modifier checksums #1954 (@cyrossignol) - refactor: [Memory optimization] Block index allocation overhead #1957 (@cyrossignol) - refactor: [Memory optimization] Remove block index subsidy fields #1960 (@cyrossignol) - refactor: [Memory optimization] Separate chain trust from the block index #1961 (@cyrossignol) - refactor: [Memory optimization] Eliminate padding between block index fields #1962 (@cyrossignol) - beacon, gui: Add check for presence of beacon private key to updateBeacon() #1968 (@jamescowens) - util: Enhance ETTS calculation #1973 (@jamescowens) - refactor: Use new clamp in util.h #1975 (@jamescowens) - gui: Redo global status for overview #1983 (@jamescowens) - util: Improvements to MilliTimer class and use in the miner and init #1987 (@jamescowens) - rpc: Move rpc files to directory #1995 (@Pythonix) - rpc: Enhance consolidateunspent and fix fee calculation #1994 (@jamescowens) - contract: Double the lookback scope of contract replay #1998 (@jamescowens) - net: Don't rely on external IP resolvers #2002 (@Tetrix42) - beacon: Change beacon map to pointers #2008 (@jamescowens) - gui: Update bitcoin_sv.ts #2014 (@sweede-se) - util: Update snapshot URLs and add accrual directory #2019 (@jamescowens) - beacon: Tweak BeaconRegistry::Revert #2020 (@jamescowens) - rpc, qt: bump fees @2023 (@div72) Removed - researcher: Remove automatic legacy beacon key import #1963 (@cyrossignol) - util: Revert "Close LevelDB after loading the block index" #1969 (@cyrossignol) - ci: Fix python symlink issue & remove travis #1990 (@div72) - ci: remove python workaround #2005 (@div72) Fixed - gui: fix mandatory/leisure detection of upgrade check #1959 (@Pythonix) - voting: Fix title in "gettransaction" RPC for legacy poll contracts @1970 (@cyrossignol) - gui: Fix missing menu items on macOS #1972 (@scribblemaniac) - rpc: Fix answer offset in "votedetails" #1974 (@cyrossignol) - voting: Implement missing try-catch in VotingVoteDialog::vote #1980 (@jamescowens) - scraper: Add check for minimum housekeeping complete in scraper #1977 (@jamescowens) - voting: Fix nonsense vote weights for legacy polls #1988 (@cyrossignol) - voting: Fix incorrect field returned in ResolveMoneySupplyForPoll() #1989 (@cyrossignol) - consensus, accrual: Fix newbie accrual #2004 (@jamescowens) - log: grammar correction #2016 (@nathanielcwm) - wallet: Correct nMinFee fee calculation in CreateTransaction #2021 (@jamescowens) - rpc, miner: Correct GetLastStake #2026 (@jamescowens) - wallet: Fix bug in CreateTransaction causing insufficient fees #2029 (@jamescowens)
gridcoin-community · Mar 1, 2021 · 454f103 · 454f103
2 parents cbd215b + 5b2a6a4
commit 454f103
Show file tree

Hide file tree

Showing 135 changed files with 406,902 additions and 2,131 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -0,0 +1,82 @@
+name: CI
+on: [push, pull_request]
+env:
+    EVENT_TYPE: ${{ github.event_name }}
+    COMMIT_COUNT: ${{ github.event.commits.length }}
+jobs:
+    test-linux:
+        name: ${{ matrix.name }}
+        runs-on: ubuntu-18.04
+        strategy:
+            matrix:
+                include:
+                  - name: ARM  [GOAL install]  [buster]
+                    script-id: arm
+                  - name: Win32
+                    script-id: win32
+                  - name: Win64
+                    script-id: win64
+                  - name: i386 Linux  [GOAL install]  [focal]
+                    script-id: linux_i386
+                  - name: x86_64 Linux  [GOAL install]  [GUI]  [focal]  [no depends]
+                    script-id: native
+                  - name: x86_64 Linux  [GOAL install]  [GUI]  [xenial]  [no depends]
+                    script-id: native_old
+                  - name: macOS 10.12  [no tests]
+                    script-id: mac
+        env:
+            FILE_ENV: ./ci/test/00_setup_env_${{ matrix.script-id }}.sh
+            OS_NAME: linux
+        steps:
+        - name: checkout
+          uses: actions/checkout@v2
+        - name: cache
+          uses: actions/cache@v2
+          with:
+            path: |
+                ./depends/built
+                ./ci/scratch/.ccache
+            key: ${{ runner.os }}-${{ matrix.script-id }}
+        - name: test
+          run: |
+            ./ci/test_run_all.sh
+    test-macos:
+        name: macOS 10.15 native  [GOAL install]  [GUI]  [no depends]
+        runs-on: macos-10.15
+        env:
+            DANGER_RUN_CI_ON_HOST: true
+            CI_USE_APT_INSTALL: no
+            FILE_ENV: ./ci/test/00_setup_env_mac_host.sh
+            OS_NAME: macos
+        steps:
+        - name: checkout
+          uses: actions/checkout@v2
+        - name: cache
+          uses: actions/cache@v2
+          with:
+            path: |
+                ./ci/scratch/.ccache
+            key: ${{ runner.os }}
+        - name: install-packages
+          run: |
+            brew install autoconf automake berkeley-db4 boost miniupnpc qrencode ccache leveldb librsvg libtool libzip openssl pkg-config python qt xquartz
+        - name: test
+          run: |
+            ./ci/test_run_all.sh
+    lint:
+        name: Lint
+        runs-on: ubuntu-latest
+        continue-on-error: true
+        steps:
+        - name: checkout
+          uses: actions/checkout@v2
+        - name: setup-python
+          uses: actions/setup-python@v2
+          with:
+            python-version: 3.5
+        - name: lint
+          continue-on-error: true
+          run: |
+            set -o errexit; source ./ci/lint/04_install.sh
+            set -o errexit; source ./ci/lint/05_before_script.sh
+            set -o errexit; source ./ci/lint/06_script.sh
diff --git a/.gitignore b/.gitignore
@@ -96,4 +96,4 @@ contrib/devtools/split-debug.sh
 *.lo
 *.la
 
-
+/doc/doxygen/
diff --git a/.travis.yml b/.travis.yml
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,66 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [5.2.0.0] 2021-03-01, mandatory, "Hilda"
+### Added
+ - gui: Add RAC column to wizard summary page projects table #1951 (@cyrossignol)
+ - rpc: clean up the superblocks function and add magnitude to getmininginfo #1966 (@jamescowens)
+ - rpc: Add transaction size to RPC output #1971 (@cyrossignol)
+ - voting: Add user-facing support for poll response types #1976 (@cyrossignol)
+ - gui: Port Bitcoin Intro class (implement the ability to choose a data directory via the GUI) #1978 (@jamescowens)
+ - gui: Port Bitcoin MacOS app nap manager #1991 (@jamescowens)
+ - mining, rpc: Implement staking efficiency measure and improve SelectCoinsForStaking and CreateCoinStake #1992 (@jamescowens)
+ - accrual, rpc: Implement auditsnapshotaccruals #2001 (@jamescowens)
+ - docs: add doxygen support #2000 (@div72)
+ - beacon: Specialized beacon storage in leveldb #2009 (@jamescowens)
+ - rpc: Add a call to dump contracts in binary form #2011 (@div72)
+ - rpc: Add boolean option to report active beacons only in beaconreport #2013 (@jamescowens)
+ - consensus: Set Hilda mainnet hardfork height to 2197000 #2022 (@jamescowens)
+
+### Changed
+ - refactor: [Memory optimization] Block index duplicate PoS state #1945 (@cyrossignol)
+ - refactor: [Memory optimization] Block index superblock and contract flags #1950 (@cyrossignol)
+ - refactor: [Memory optimization] Remove stake modifier checksums #1954 (@cyrossignol)
+ - refactor: [Memory optimization] Block index allocation overhead #1957 (@cyrossignol)
+ - refactor: [Memory optimization] Remove block index subsidy fields #1960 (@cyrossignol)
+ - refactor: [Memory optimization] Separate chain trust from the block index #1961 (@cyrossignol)
+ - refactor: [Memory optimization] Eliminate padding between block index fields #1962 (@cyrossignol)
+ - beacon, gui: Add check for presence of beacon private key to updateBeacon() #1968 (@jamescowens)
+ - util: Enhance ETTS calculation #1973 (@jamescowens)
+ - refactor: Use new clamp in util.h #1975 (@jamescowens)
+ - gui: Redo global status for overview #1983 (@jamescowens)
+ - util: Improvements to MilliTimer class and use in the miner and init #1987 (@jamescowens)
+ - rpc: Move rpc files to directory #1995 (@Pythonix)
+ - rpc: Enhance consolidateunspent and fix fee calculation #1994 (@jamescowens)
+ - contract: Double the lookback scope of contract replay #1998 (@jamescowens)
+ - net: Don't rely on external IP resolvers #2002 (@Tetrix42)
+ - beacon: Change beacon map to pointers #2008 (@jamescowens)
+ - gui: Update bitcoin_sv.ts #2014 (@sweede-se)
+ - util: Update snapshot URLs and add accrual directory #2019 (@jamescowens)
+ - beacon: Tweak BeaconRegistry::Revert #2020 (@jamescowens)
+ - rpc, qt: bump fees @2023 (@div72)
+
+### Removed
+ - researcher: Remove automatic legacy beacon key import #1963 (@cyrossignol)
+ - util: Revert "Close LevelDB after loading the block index" #1969 (@cyrossignol)
+ - ci: Fix python symlink issue & remove travis #1990 (@div72)
+ - ci: remove python workaround #2005 (@div72)
+
+### Fixed
+ - gui: fix mandatory/leisure detection of upgrade check #1959 (@Pythonix)
+ - voting: Fix title in "gettransaction" RPC for legacy poll contracts @1970 (@cyrossignol)
+ - gui: Fix missing menu items on macOS #1972 (@scribblemaniac)
+ - rpc: Fix answer offset in "votedetails" #1974 (@cyrossignol)
+ - voting: Implement missing try-catch in VotingVoteDialog::vote #1980 (@jamescowens)
+ - scraper: Add check for minimum housekeeping complete in scraper #1977 (@jamescowens)
+ - voting: Fix nonsense vote weights for legacy polls #1988 (@cyrossignol)
+ - voting: Fix incorrect field returned in ResolveMoneySupplyForPoll() #1989 (@cyrossignol)
+ - consensus, accrual: Fix newbie accrual #2004 (@jamescowens)
+ - log: grammar correction #2016 (@nathanielcwm)
+ - wallet: Correct nMinFee fee calculation in CreateTransaction #2021 (@jamescowens)
+ - rpc, miner: Correct GetLastStake #2026 (@jamescowens)
+ - wallet: Fix bug in CreateTransaction causing insufficient fees #2029 (@jamescowens)
+
 ## [5.1.0.0] 2020-11-01, mandatory, "Gladys"
 ### Added
  - rpc: Add out-of-sync status to "getinfo" and "getblockchaininfo" #1925 (@cyrossignol)

diff --git a/Makefile.am b/Makefile.am
@@ -207,6 +207,21 @@ CLEANFILES = $(OSX_DMG) $(BITCOIN_WIN_INSTALLER)
 
 DISTCHECK_CONFIGURE_FLAGS = --enable-man
 
-clean-local:
+doc/doxygen/.stamp: doc/Doxyfile FORCE
+	$(MKDIR_P) $(@D)
+	$(DOXYGEN) $^
+	$(AM_V_at) touch $@
+
+if HAVE_DOXYGEN
+docs: doc/doxygen/.stamp
+else
+docs:
+	@echo "error: doxygen not found"
+endif
+
+clean-docs:
+	rm -rf doc/doxygen
+
+clean-local: clean-docs
 	rm -rf coverage_percent.txt test_bitcoin.coverage/ total.coverage/ test/tmp/ cache/ $(OSX_APP)
 	rm -rf test/functional/__pycache__
diff --git a/ci/lint/04_install.sh b/ci/lint/04_install.sh
@@ -6,14 +6,14 @@
 
 export LC_ALL=C
 
-travis_retry sudo apt update && sudo apt install -y clang-format-9
+./ci/retry/retry sudo apt update && sudo apt install -y clang-format-9
 sudo update-alternatives --install /usr/bin/clang-format      clang-format      $(which clang-format-9     ) 100
 sudo update-alternatives --install /usr/bin/clang-format-diff clang-format-diff $(which clang-format-diff-9) 100
 
-travis_retry pip3 install codespell==1.17.1
-travis_retry pip3 install flake8==3.8.3
-travis_retry pip3 install yq
-travis_retry pip3 install mypy==0.781
+./ci/retry/retry pip3 install codespell==1.17.1
+./ci/retry/retry pip3 install flake8==3.8.3
+./ci/retry/retry pip3 install yq
+./ci/retry/retry pip3 install mypy==0.781
 
 SHELLCHECK_VERSION=v0.7.1
 curl -sL "https://github.com/koalaman/shellcheck/releases/download/${SHELLCHECK_VERSION}/shellcheck-${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" | tar --xz -xf - --directory /tmp/

diff --git a/ci/lint/06_script.sh b/ci/lint/06_script.sh
@@ -10,6 +10,9 @@ if [ "$TRAVIS_EVENT_TYPE" = "pull_request" ]; then
   test/lint/commit-script-check.sh $TRAVIS_COMMIT_RANGE
 fi
 
+if [ "$EVENT_TYPE" = "pull_request" ]; then
+  test/lint/commit-script-check.sh $(git rev-parse HEAD~$COMMIT_COUNT)..$GITHUB_SHA
+fi
 #test/lint/git-subtree-check.sh src/crypto/ctaes
 #test/lint/git-subtree-check.sh src/secp256k1
 #test/lint/git-subtree-check.sh src/univalue

diff --git a/ci/test/00_setup_env_mac.sh b/ci/test/00_setup_env_mac.sh
@@ -16,3 +16,4 @@ export RUN_FUNCTIONAL_TESTS=false
 export GOAL=""
 export DEP_OPTS="NO_QT=1"
 export GRIDCOIN_CONFIG="--enable-reduce-exports"
+export NEED_XVFB="false"
diff --git a/ci/test/03_before_install.sh b/ci/test/03_before_install.sh
@@ -9,12 +9,20 @@ export LC_ALL=C.UTF-8
 BEGIN_FOLD () {
   echo ""
   CURRENT_FOLD_NAME=$1
-  echo "travis_fold:start:${CURRENT_FOLD_NAME}"
+  if [ "$TRAVIS" == "true" ]; then
+    echo "travis_fold:start:${CURRENT_FOLD_NAME}"
+  else
+    echo "::group::${CURRENT_FOLD_NAME}"
+  fi
 }
 
 END_FOLD () {
   RET=$?
-  echo "travis_fold:end:${CURRENT_FOLD_NAME}"
+  if [ "$TRAVIS" == "true" ]; then
+    echo "travis_fold:end:${CURRENT_FOLD_NAME}"
+  else
+    echo "::endgroup::"
+  fi
   if [ $RET != 0 ]; then
     echo "${CURRENT_FOLD_NAME} failed with status code ${RET}"
   fi

diff --git a/ci/test/04_install.sh b/ci/test/04_install.sh
@@ -54,17 +54,21 @@ if [ -n "$DPKG_ADD_ARCH" ]; then
 fi
 
 if [[ $DOCKER_NAME_TAG == centos* ]]; then
+  BEGIN_FOLD yum
   ${CI_RETRY_EXE} DOCKER_EXEC yum -y install epel-release
   ${CI_RETRY_EXE} DOCKER_EXEC yum -y install $DOCKER_PACKAGES $PACKAGES
+  END_FOLD
 elif [ "$CI_USE_APT_INSTALL" != "no" ]; then
+  BEGIN_FOLD apt
   ${CI_RETRY_EXE} DOCKER_EXEC apt-get update
   ${CI_RETRY_EXE} DOCKER_EXEC apt-get install --no-install-recommends --no-upgrade -y $PACKAGES $DOCKER_PACKAGES
   if [ "$NEED_XVFB" == "true" ]; then
     ${CI_RETRY_EXE} DOCKER_EXEC apt-get install --no-install-recommends --no-upgrade -y xvfb
   fi
+  END_FOLD
 fi
 
-if [ "$TRAVIS_OS_NAME" == "osx" ]; then
+if [ "$OS_NAME" == "macos" ]; then
   top -l 1 -s 0 | awk ' /PhysMem/ {print}'
   echo "Number of CPUs: $(sysctl -n hw.logicalcpu)"
 else
Original file line number	Diff line number	Diff line change
Expand Up		@@ -96,4 +96,4 @@ contrib/devtools/split-debug.sh
		*.lo
		*.la


		/doc/doxygen/