Adding support for multisig accounts #384
Conversation
aaroncox
commented
Feb 23, 2025
•
aaroncox
commented
- multisig wallet plugin
- account authority page
- multisig session display
- multisig options in settings page
- rework of resources display
- added datetime input
- removed reference to pwa manifest
- added support for time.eosn contract for checktime action in multisigs
- improved filtering on activity page to prevent duplicates
- misc supporting fixes/chanegs
Deploying 2nicove with
|
| Latest commit: |
39af9c9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62d32969.unicove2.pages.dev |
| Branch Preview URL: | https://multisig.unicove2.pages.dev |
| <div class="text-left font-medium"> | ||
| <div>{session.actor}@{session.permission}</div> | ||
| {#if session.walletPlugin.id === 'wallet-plugin-multisig'} | ||
| <div class="text-xs"> | ||
| ↳ multisig using {session.walletPlugin.data.session.actor} | ||
| </div> | ||
| {/if} | ||
| </div> |
There was a problem hiding this comment.
I'm curious what this looks like in context with layout, the arrow glyph, and the small text.
Probably should use a translation here too?
There was a problem hiding this comment.
Here's what it looks like. I've updated all the translations in the account switcher here: e692369
There was a problem hiding this comment.
It might call for a slightly lighter-weight font in the second line, but otherwise looks good.
I'm always hesitant to use glyphs in the font vs an svg because they can become unpredicatable with different fonts, different browser settings, zoom levels, but more importantly: it's decorative, so it shouldn't be included in the text string (which will be translated at some point)
There was a problem hiding this comment.
Yeah totally understood. We probably want a "real" design for these elements, since as I worked on this I was just implementing my developer design to make something available.
I'm very open to change with how its displayed.
| The multi-sig proposal for this transaction has been created and now needs to be approved. | ||
| View the proposal below and share it with the parties who need to sign. |
There was a problem hiding this comment.
Should we be picky about translations at this point?
There was a problem hiding this comment.
We probably should get better about this, and have someone in charge of that entire pipeline. Considering we're not 100% translated right now though, I don't know if it should be a barrier?
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| import { ApprovalManager } from './manager.svelte'; | |||
| import type { ActionDisplayVariants } from '$lib/types'; | |||
| import { goto } from '$app/navigation'; | |||
There was a problem hiding this comment.
Wonder if we should use the wrapped goto from $lib/utils so the language tag is included
There was a problem hiding this comment.
Good call, one less redirect!
There was a problem hiding this comment.
Updated a few pages where this made sense.
static/_site.webmanifest
Outdated
There was a problem hiding this comment.
Do we still need to rename this file if we're not linking to it in the <head> anymore?
There was a problem hiding this comment.
No, probably not. I'll undo the rename.
| </fieldset> | ||
| <fieldset class="grid gap-3"> | ||
| {#if ramBytesUseCustom} | ||
| <SingleCard> |
There was a problem hiding this comment.
This component was designed with page-level layout in mind. Will have to evaluate how it works in this context.
There was a problem hiding this comment.
I'm probably using a bunch of components wrong 😅
This page in particular shouldn't have even been committed. It is just a copy of one of the other forms, that I never got around to using. I'll delete it for the time being.
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| interface Props { | |||
| options: ExtendedSelectOption[]; | |||
| selected: ExtendedSelectOption; | |||
| selected?: ExtendedSelectOption; | |||
There was a problem hiding this comment.
IIRC this was required in the melt-ui builder so I made it required in the interface
There was a problem hiding this comment.
I'll revert this change and force a default option on the settings page then.
The select element with a default option ands up triggering the effects on the page, setting the value to whatever the select believes the default option should be. This could override defaults set elsewhere.
So there's some funk in here at the moment we should try to figure out how to address.
There was a problem hiding this comment.
I agree, we should address the funk and see if we can make selected optional. It does make sense to have the option to create a dropdown with nothing selected and no default.
| <Card> | ||
| <div class="flex"> | ||
| <div class="flex-1"> | ||
| <Account name={auth.account_name} class="h2"> |
There was a problem hiding this comment.
Based on the video in Slack, this should probably be smaller than h2 since it's competing in prominence with the page header. Try h3 or h4
Co-authored-by: Dean Sallinen <[email protected]>
