Greta array print 480 #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njtierney
added a commit
to njtierney/greta
that referenced
this pull request
Jul 29, 2024
…e shorter and more informative. (greta-dev#644)
devtools::load_all(".")
#> ℹ Loading greta
#> ℹ Initialising python and checking dependencies, this may take a moment.
#>
#> ✔ Initialising python and checking dependencies ... done!
print_h1.greta_array(normal(0, 1, dim = 15))
#>
#> ── greta array <variable following a normal distribution> ──────────────────────
#> [,1]
#> [1,] ?
#> [2,] ?
#> [3,] ?
#> [4,] ?
#> [5,] ?
#> [6,] ?
#> [7,] ?
#> [8,] ?
#> [9,] ?
#> [10,] ?
#>
#> ℹ 5 more values
#> Use `print(n = ...)` to see more values
print_h2.greta_array(normal(0, 1, dim = 15))
#>
#> ── greta array <variable following a normal distribution> ──
#> [,1]
#> [1,] ?
#> [2,] ?
#> [3,] ?
#> [4,] ?
#> [5,] ?
#> [6,] ?
#> [7,] ?
#> [8,] ?
#> [9,] ?
#> [10,] ?
#>
#> ℹ 5 more values
#> Use `print(n = ...)` to see more values
print_h3.greta_array(normal(0, 1, dim = 15))
#>
#> ── greta array <variable following a normal distribution>
#> [,1]
#> [1,] ?
#> [2,] ?
#> [3,] ?
#> [4,] ?
#> [5,] ?
#> [6,] ?
#> [7,] ?
#> [8,] ?
#> [9,] ?
#> [10,] ?
#>
#> ℹ 5 more values
#> Use `print(n = ...)` to see more values
print(normal(0, 1, dim = 15))
#> greta array <variable following a normal distribution>
#> [,1]
#> [1,] ?
#> [2,] ?
#> [3,] ?
#> [4,] ?
#> [5,] ?
#> [6,] ?
#> [7,] ?
#> [8,] ?
#> [9,] ?
#> [10,] ?
#>
#> ℹ 5 more values
#> Use `print(n = ...)` to see more valuesCreated on 2024-07-29 with reprex v2.1.0
|
njtierney
force-pushed
the
greta-array-print-480
branch
from
04d4147 to
e614030
Compare
|
There is also some opportunity here to add more text highlighting for the different nodes:
Which might be nice. |
|
So nice in fact that I got really deep into a cli formatting rabbithole. Behold! library(greta)
#>
#> Attaching package: 'greta'
#> The following objects are masked from 'package:stats':
#>
#> binomial, cov2cor, poisson
#> The following objects are masked from 'package:base':
#>
#> %*%, apply, backsolve, beta, chol2inv, colMeans, colSums, diag,
#> eigen, forwardsolve, gamma, identity, rowMeans, rowSums, sweep,
#> tapply
ga_data <- as_data(matrix(1:9, nrow = 3))
#> ℹ Initialising python and checking dependencies, this may take a moment.
#> ✔ Initialising python and checking dependencies ... done!
#>
ga_stochastic <- normal(0, 1)
ga_operation <- ga_data * ga_stochastic
ga_data
#> greta array <data>
#> [,1] [,2] [,3]
#> [1,] 1 4 7
#> [2,] 2 5 8
#> [3,] 3 6 9
ga_stochastic
#> greta array <variable following a normal distribution>
#> [,1]
#> [1,] ?
#>
ga_operation
#> greta array <operation>
#> [,1] [,2] [,3]
#> [1,] ? ? ?
#> [2,] ? ? ?
#> [3,] ? ? ?
#>
normal(0, 1, dim = 10)
#> greta array <variable following a normal distribution>
#> [,1]
#> [1,] ?
#> [2,] ?
#> [3,] ?
#> [4,] ?
#> [5,] ?
#> [6,] ?
#> [7,] ?
#> [8,] ?
#> [9,] ?
#> [10,] ?
#>
normal(0, 1, dim = 15)
#> greta array <variable following a normal distribution>
#> [,1]
#> [1,] ?
#> [2,] ?
#> [3,] ?
#> [4,] ?
#> [5,] ?
#> [6,] ?
#> [7,] ?
#> [8,] ?
#> [9,] ?
#> [10,] ?
#>
#> ℹ 5 more values
#> Use `print(n = ...)` to see more values
print(normal(0, 1, dim = 15), n = 15)
#> greta array <variable following a normal distribution>
#>
#> [,1]
#> [1,] ?
#> [2,] ?
#> [3,] ?
#> [4,] ?
#> [5,] ?
#> [6,] ?
#> [7,] ?
#> [8,] ?
#> [9,] ?
#> [10,] ?
#> [11,] ?
#> [12,] ?
#> [13,] ?
#> [14,] ?
#> [15,] ?
#> Created on 2024-07-29 with reprex v2.1.0
|
|
Underlying print method for
So we might need to implement a wrapper class on top of this, as the other print methods use Or we might need to work with |
|
Any of these are a big improvement on existing - I'm all for anything that reduced the need to use |
… to do this that is more elegant but this will work for the time being
pretty CLI comparison
Before
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would improve print methods for MCMC and for greta arrays.
This will resolve #480
Keen to get some user input, will post examples in this PR thread.