Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a python_deps argument in install_greta_deps() and create known sets of working installers #666

Closed
njtierney opened this issue Aug 5, 2024 · 0 comments

Comments

@njtierney
Copy link
Collaborator

njtierney commented Aug 5, 2024

Related to #664 and #638

So instead of

install_greta_deps <- function(method = c("auto", "virtualenv", "conda"),
                               conda = "auto",
                               timeout = 5,
                               scheme = c("default", "tf213", "manual", "aws"),
                               manual = FALSE,
                               restart = c("ask", "force", "no"),
                               ...) {
...
}

It will be something like:

install_greta_deps <- function(py_deps = greta_python_deps(),
                               restart = c("ask", "force", "no"),
                               timeout = 5,
                               ...) {
...
}

Then you can create your own specs that work, or use some existing ones, e.g.,

aws_install <- greta_python_deps(
  tf_version = "2.11.0",
  tfp_version = "0.19.0",
  keras_version = NULL,
  py_version = "3.8.15"
)

install_greta_deps(py_deps = aws_install)

And also we could create a set of known install sets that work and provide them as objects within greta, e.g.,

# macOS
install_greta_deps(py_deps = .greta_deps_macos)
# windows
install_greta_deps(py_deps = .greta_deps_windows)
# linux
install_greta_deps(py_deps = .greta_deps_windows)
# linux
install_greta_deps(py_deps = .greta_deps_aws)
@njtierney njtierney moved this from Backlog to Weekly Todo in {greta} CRAN 0.5.0 release Aug 5, 2024
@njtierney njtierney moved this from Weekly Todo to In Progress in {greta} CRAN 0.5.0 release Aug 6, 2024
njtierney added a commit to njtierney/greta that referenced this issue Aug 6, 2024
njtierney added a commit to njtierney/greta that referenced this issue Aug 7, 2024
…TFP, and Python(greta-dev#666)

* Added data `greta_deps_tf_tfp` (greta-dev#666), which contains valid versions combinations of TF, TFP, and Python.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant