Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "restart R?" yesno option when running install_greta_deps() #523

Closed
njtierney opened this issue May 19, 2022 · 2 comments
Closed

Add "restart R?" yesno option when running install_greta_deps() #523

njtierney opened this issue May 19, 2022 · 2 comments
Labels
impact-1 High impact issue installation low hanging fruit Issue is simple to implement. Up Next
Milestone
0.5.0

Comments

@njtierney
Copy link
Collaborator

  • only shows up when interactive() returns TRUE (to avoid issues with scripting and restarting R without asking)
  • or potentially add a restart = FALSE option in install_greta_deps() instead/in addition?
@njtierney njtierney mentioned this issue May 19, 2022
Closed
@njtierney njtierney added this to the 0.5.0 milestone May 19, 2022
@njtierney njtierney modified the milestones: 0.5.0, 0.6.0 Feb 8, 2023
@njtierney njtierney added Up Next low hanging fruit Issue is simple to implement. impact-1 High impact issue labels Jul 24, 2024
@njtierney njtierney modified the milestones: 0.6.0, 0.5.0 Jul 25, 2024
@njtierney njtierney moved this from Backlog to Weekly Todo in {greta} CRAN 0.5.0 release Jul 30, 2024
@njtierney
Copy link
Collaborator Author

Something like:

Would you like to restart R now: (yesno options)

with the restart R option, it could even have something that restarts R and runs library(greta)

.rs.restartR(afterRestartCommand = "library(greta)")

@njtierney njtierney mentioned this issue Aug 1, 2024
Closed
njtierney added a commit to njtierney/greta that referenced this issue Aug 1, 2024
@njtierney
- restart argument for install_greta_deps() and `reinstall_greta_…
0b546e8 
…deps()` to automatically restart R (greta-dev#523)
@njtierney njtierney mentioned this issue Aug 1, 2024
Closed
@njtierney njtierney moved this from Weekly Todo to In Progress in {greta} CRAN 0.5.0 release Aug 1, 2024
@njtierney
Copy link
Collaborator Author

Closed in #672

@github-project-automation github-project-automation bot moved this from In Progress to Done in {greta} CRAN 0.5.0 release Aug 6, 2024
njtierney added a commit to njtierney/greta that referenced this issue Aug 6, 2024
@njtierney
* Added option to restart R + run library(greta) after installation (…
7b9eb5c 
…greta-dev#523)

* Added installation deps object, `greta_python_deps()` to help simplify specifying package versions (greta-dev#664)
* removed `method` and `conda` arguments from `install_greta_deps()` as they
  were not used.
* removed `manual` option in `install_greta_deps()`
* added default 5 minute timer to installation processes
@njtierney njtierney mentioned this issue Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact-1 High impact issue installation low hanging fruit Issue is simple to implement. Up Next
Projects
No open projects
{greta} CRAN 0.5.0 release
Status: Done
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@njtierney