Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

music: remove seek_step, add seek_step_secs #1718

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Conversation

MaxVerevkin
Copy link
Collaborator

"Number of microseconds to seek..." doesn't seem very user-friendly. In addition, the default value was clearly wrong (0.001 second).

Renamed seek_step to seek_step_secs not to silently break configs.

@MaxVerevkin MaxVerevkin added the breaking Breaking changes label Feb 7, 2023
@bim9262 bim9262 mentioned this pull request Feb 11, 2023
@MaxVerevkin MaxVerevkin merged commit efa7b55 into master Feb 11, 2023
@MaxVerevkin MaxVerevkin deleted the music_seek_step_secs branch February 11, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant