forked from opencast/opencast
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hint at how to properly close issues with pull requests (opencast#5257)
Mentioning issues in your PR with some magic keywords can automatically close these issues when the PR is merged. We even hint at this in our PR-template already. However, GitHubs implementation of this does not work super well with our release/branching model. Specifically, it only works if the PR is merged into the default branch, which is `develop` in our case. It **can** be made to work in our situation if the magic phrases are mentioned in commit messages alternatively or in addition to the PR description, because we regularly forward merge the release branches. This patch adds a corresponding note about this to the documentation, and links it in the PR template.
- Loading branch information
Showing
2 changed files
with
28 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters