Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update contributors link in CONTRIBUTING.md #394

Merged

Conversation

michaeljaltamirano
Copy link
Contributor

@michaeljaltamirano michaeljaltamirano commented Jan 30, 2020

Summary

It seems Github may have changed its Contributors URL since this was initially set up. The current href directs you to https://github.com/gregberge/svgr/blob/master/graphs/contributors, which is a broken page. The functioning page is https://github.com/gregberge/svgr/graphs/contributors, so I've inlined it in the href.

Test plan

Functionality on master breaks: https://github.com/gregberge/svgr/blob/master/CONTRIBUTING.md#credits

Functionality on fix branch works: https://github.com/michaeljaltamirano/svgr/blob/docs/update-contributors-link/CONTRIBUTING.md#credits

@vercel
Copy link

vercel bot commented Jan 30, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/gregberge/svgr/db7p5fauo
✅ Preview: https://svgr-git-fork-michaeljaltamirano-docs-update-contributors-link.gregberge.now.sh

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #394 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files          30       30           
  Lines         518      518           
  Branches      142      142           
=======================================
  Hits          443      443           
  Misses         62       62           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09bcd5...6f45c3f. Read the comment docs.

@gregberge gregberge merged commit dd89778 into gregberge:master Feb 2, 2020
@gregberge
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants