Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(options): correct dimensions default #258

Merged
merged 1 commit into from
Jan 4, 2019
Merged

docs(options): correct dimensions default #258

merged 1 commit into from
Jan 4, 2019

Conversation

TheSharpieOne
Copy link
Contributor

Summary

The docs currently indicate that the default value for dimensions is false, but it appears to be true: https://github.com/smooth-code/svgr/blob/d112dd287fb1c369bc6caf97807369d827de5528/packages/core/src/config.js#L5
This caused some confusion.

Test plan

N/A

@vercel
Copy link

vercel bot commented Jan 2, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files          30       30           
  Lines         448      448           
  Branches      125      125           
=======================================
  Hits          382      382           
  Misses         55       55           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d112dd2...8e965b6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files          30       30           
  Lines         448      448           
  Branches      125      125           
=======================================
  Hits          382      382           
  Misses         55       55           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d112dd2...8e965b6. Read the comment docs.

@gregberge
Copy link
Owner

You are right! Nice catch!

@gregberge gregberge merged commit 93b6fa0 into gregberge:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants