Cover directory options with tests and remove lodash #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lodash is quite big and importing whole library is expensive even in node. Path based imports are also have a big dependency tree. `camelcase` package covers both pascal and camel cases `dashify` is a replacement for kebab-case `merge-deep` covers all `mergeConfigs` tests
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 88.73% 88.91% +0.17%
==========================================
Files 26 25 -1
Lines 435 424 -11
Branches 79 78 -1
==========================================
- Hits 386 377 -9
+ Misses 47 45 -2
Partials 2 2
Continue to review full report at Codecov.
|
|
Thanks for removing lodash! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lodash is quite big and importing whole library is expensive even in
node. Path based imports are also have a big dependency tree.
camelcasepackage covers both pascal and camel casesdashifyis a replacement for kebab-casemerge-deepcovers allmergeConfigstests