[FEATURE] Experimental Python 3.12 support #8862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Kilo59
commented
Oct 24, 2023
Comment on lines
+342
to
+344
| parser = configparser.ConfigParser() | ||
| with open(setup_cfg) as f: | ||
| parser.readfp(f) | ||
| parser.read_file(f) |
There was a problem hiding this comment.
only install for cloud tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8862 +/- ##
===========================================
- Coverage 79.55% 79.55% -0.01%
===========================================
Files 456 456
Lines 39407 39410 +3
===========================================
+ Hits 31351 31353 +2
- Misses 8056 8057 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Kilo59
commented
May 28, 2024
Kilo59
commented
May 28, 2024
reqs/requirements-dev-clickhouse.txt
Outdated
Comment on lines
1
to
4
| clickhouse-sqlalchemy>=0.2.2; python_version < "3.12" | ||
| clickhouse-sqlalchemy>=0.3.0; python_version >= "3.12" # SQLALchemy 2 support added in 0.3.0 | ||
| pandas<2.2.0; python_version >= "3.9" | ||
| pandas>=2.0.0; python_version <= "3.12" |
There was a problem hiding this comment.
SQLAlchemy 2.0 support was added
https://github.com/xzkostyan/clickhouse-sqlalchemy/blob/master/CHANGELOG.md#030---2023-11-06
I believe this is why we are restricting the pandas version. I think we can lift this restriction for all versions of python.
Kilo59
commented
Jun 17, 2024
reqs/requirements-dev-lite.txt
Outdated
| responses>=0.23.1 # requests mocking | ||
| snapshottest==0.6.0 # GX Cloud atomic renderer tests | ||
| setuptools>=70.0.0 |
There was a problem hiding this comment.
package_resources is part of setuptools, and not installed by default for Python 3.12.
See related issue in a different project.
Kilo59
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to make
great_expectationsand the test CI compatible with Python 3.12.To install
great_expectationson Python 3.12 aGX_PYTHON_EXPERIMENTALenvironment variable must be set.Changes
configparserhttps://docs.python.org/3.12/whatsnew/3.12.html#configparsersnapshottestrunning in CI for3.12datetimeusage warnings.DTZruff rule to include test usagemototo deal withsslchanges. - https://docs.getmoto.org/en/latest/docs/releases.htmlpython_requirest = ">=3.8,<3.12"unlessGX_PYTHON_EXPERIMENTALenv var is found.Notes
Waiting on pandas support for3.12before resuming this work.CI currently installspact-pythonfor every test job (even if it isn't being used).Python 3.12 Release pact-foundation/pact-python#405
We can work around this by skipping installs for the pact tests for3.12until support is added.possible
snapshottestreplacement - https://tophat.github.io/syrupy/