Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Remove duplicate RegexPatternStringParameterBuilder test #4241

Merged
merged 1 commit into from
Feb 20, 2022
Merged

[BUGFIX] Remove duplicate RegexPatternStringParameterBuilder test #4241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions tests/rule_based_profiler/parameter_builder/test_regex_pattern_string_parameter_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,64 +193,6 @@ def test_regex_pattern_string_parameter_builder_bobby_multiple_matches(
assert results["details"] == expected_value["details"]


def test_regex_pattern_string_parameter_builder_bobby_no_match(
bobby_columnar_table_multi_batch_deterministic_data_context,
):
data_context: DataContext = (
bobby_columnar_table_multi_batch_deterministic_data_context
)
metric_domain_kwargs: dict = {"column": "VendorID"}
candidate_regexes: Set[str] = {
r"^\d{3}$", # won't match
}
threshold: float = 0.9
batch_request: dict = {
"datasource_name": "taxi_pandas",
"data_connector_name": "monthly",
"data_asset_name": "my_reports",
"data_connector_query": {"index": -1},
}

regex_parameter: RegexPatternStringParameterBuilder = (
RegexPatternStringParameterBuilder(
name="my_regex_pattern_string_parameter_builder",
metric_domain_kwargs=metric_domain_kwargs,
candidate_regexes=candidate_regexes,
threshold=threshold,
data_context=data_context,
batch_request=batch_request,
)
)
parameter_container: ParameterContainer = ParameterContainer(parameter_nodes=None)
domain: Domain = Domain(
domain_type=MetricDomainTypes.COLUMN, domain_kwargs=metric_domain_kwargs
)

assert parameter_container.parameter_nodes is None

regex_parameter._build_parameters(
parameter_container=parameter_container, domain=domain
)

fully_qualified_parameter_name_for_value: str = (
"$parameter.my_regex_pattern_string_parameter_builder"
)
expected_value: dict = {
"value": [],
"details": {"success_ratio": []},
}

assert (
get_parameter_value_by_fully_qualified_parameter_name(
fully_qualified_parameter_name=fully_qualified_parameter_name_for_value,
domain=domain,
parameters={domain.id: parameter_container},
)
== expected_value
)


# Chetan - 20220219 - This needs to be renamed to prevent a namespace collision
def test_regex_pattern_string_parameter_builder_bobby_no_match(
bobby_columnar_table_multi_batch_deterministic_data_context,
):
Expand Down