Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technical term data asset #4211

Conversation

Rachel-Reverie
Copy link
Contributor

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Updates the Data Asset technical term page that was created in abbreviated form for a community meetup demo, bringing it up to the standards for a full technical term page.

After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Definition of Done

Please delete options that are not relevant.

  • I have made corresponding changes to the documentation

Thank you for submitting!

@netlify
Copy link

netlify bot commented Feb 15, 2022

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: 4e43a5b

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/620c0bff20de7700071d305f

😎 Browse the preview: https://deploy-preview-4211--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

Copy link
Contributor

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jcampbell jcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rachel-Reverie I really like this. I'd like to include the specific verbiage of "Reference", "Event" and "Ticket" data in the section on versatility--that represents an update to the language currently there.

@Rachel-Reverie
Copy link
Contributor Author

@jcampbell Can you provide some further detail on that, or link me to somewhere where those terms are defined? I didn't come across them when I was compiling this doc, and I'm not familiar with the conversations where they've been coming up. Thanks!

@Rachel-Reverie
Copy link
Contributor Author

@jcambell I've added a ticket to update the verbage and add images based on the lucid diagram you shared, but I'm going to go ahead and merge the current content now so that the whole universal-map-update branch can be prepped to merge into develop.

@Rachel-Reverie Rachel-Reverie merged commit 217ea96 into universal-map-docs-update Feb 25, 2022
@Rachel-Reverie Rachel-Reverie deleted the DOCS/DOC-95/DOC-124/technical_term_data_asset branch February 25, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants