-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Fix sidebar highlight by deleting subpages from the sidebar #10903
base: develop
Are you sure you want to change the base?
[DOCS] Fix sidebar highlight by deleting subpages from the sidebar #10903
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
40490e4
to
4d4e554
Compare
4d4e554
to
515b2e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense for desktop view but it makes the menu less functional on mobile. Can we test keeping the menu as if for small screens?
Jira Ticket
Deploy Preview
Description
We decided on deleting that wrapper customization since it was causing more bugs than fixing the only thing that we originally intended to fix:
Originally we wanted the subpages in the left sidebar to be highlighted when selected. They weren't being highlighted because they were only subtitles and not actual pages. For docusaurus to highight them we added that wrapper that also took into consideration the hash part.
But bugs like the one stated in the jira ticket started occurring so we decided to delete the "subpages" since it did not make sense to have them in the first place (we have the table of contents at the right side of the screen that was serving the exact same purpose but working properly.
invoke lint
(usesruff format
+ruff check
)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!