Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added $promptError as an additional parameter to execute() #23

Merged
merged 5 commits into from
Sep 10, 2019

Conversation

kinekt4
Copy link
Contributor

@kinekt4 kinekt4 commented Aug 29, 2019

As proposed in issue #18 and finally making the change today, I've added the $promtError parameter to the execute method.

This allows $promptError to be evaluated dynamically (per execute call) rather than statically (only on connect) as is done currently.

I've added a unit test method. I've run this manually using phpunit (instead of make test).

@kinekt4
Copy link
Contributor Author

kinekt4 commented Aug 29, 2019

Travis build fails on HHVM build jobs.

Looking into it further, it seems composer no longer supports HHVM:

composer/composer#8127

@biggianteye biggianteye merged commit ed36256 into graze:master Sep 10, 2019
@biggianteye
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants