Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove operator label on ATM #5055

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

dch0ph
Copy link
Contributor

@dch0ph dch0ph commented Jan 19, 2025

Fixes #4575

Changes proposed in this pull request:
There was agreement in the discussion of #4575 that the current rendering of the operator tag on ATMs was unsatisfactory: adding visual clutter for map users, and not providing useful feedback for mappers. Overall, removing the labelling seemed the best option.

Test rendering with links to the example places:

Example where decluttering is helpful:

Before

image

After

image

Note helpful de-duplication of bank vs ATM names, in particular when the bank name is now visible (HSBC UK in bottom right)

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as intended.

before:
before

after:
after

As indicated in #4575 i am in support of this - as the approach with most support and as a cautionary approach to labeling to avoid problematic mapping incentives.

@imagico imagico merged commit d7c3aec into gravitystorm:master Feb 10, 2025
2 checks passed
@dch0ph dch0ph deleted the remove-ATM-operator-label branch February 14, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Considering showing brand not operator for amenity=atm labels
2 participants