Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link roads the same z_order as their base class #4052

Closed
wants to merge 1 commit into from

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Mar 6, 2020

By adding link status to the ORDER BY this then allows the ordering
logic to be changed at low zoom or in forks.

Tested locally at several complex interchanges and everything looks as it does on tile.osm.org.

Fixes #3719

By adding link status to the ORDER BY this then allows the ordering
logic to be changed at low zoom or in forks.
@jeisenbe jeisenbe added the code label Mar 6, 2020
@jeisenbe
Copy link
Collaborator

jeisenbe commented Mar 6, 2020

This reminds me that we had intended to add construction=* to the z_order list to fix inconsistent ordering of highway=construction types, as mentioned in #3579 and the initial version of PR #3646.

Would you be willing to add the z_order for different values of construction= to this PR, for example something like this commit: 810448b ? Or else I can open a separate PR.

@pnorman
Copy link
Collaborator Author

pnorman commented Mar 6, 2020

Let's keep them in different PRs

Copy link
Collaborator

@jeisenbe jeisenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked test renderings with various types of link roads, paths, tracks, service, residential etc and it is unchanged. - Oops, I checked out the wrong branch, let's try that again.

Copy link
Collaborator

@jeisenbe jeisenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now that I've checked out the right branch, there are some visual changes in rare situations, when a highway=path, track, service or similar low-priority road crosses or meets a link.

These changes are not huge, but perhaps they were not intentional?

Before:

  • Links above service/road/path/track

link-roads-before

After:

  • Links below

link-roads-after

Can we fix this?

@pnorman
Copy link
Collaborator Author

pnorman commented Mar 6, 2020

Thinking about this, it's not going to work with our peculiar ordering of links between high-class roads and low-class roads.

@pnorman pnorman closed this Mar 6, 2020
@pnorman pnorman mentioned this pull request Mar 7, 2020
@pnorman pnorman deleted the link_order branch April 7, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rescale z_order and treat links the same as base type
2 participants