Import the key "golf=" as polygon features, with exceptions for golf=hole, path and cartpath #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add golf key to list of polygon keys in openstreetmap-carto.lua so that closed ways with this key will be imported as polygons, except for golf=hole, golf=path and golf=cartpath which are always mapped as lines
jeisenbe
changed the title
pnorman
approved these changes
Feb 6, 2020
|
Fixed the merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3611 and #661
Changes proposed in this pull request:
golfkey to list of polygon keys in openstreetmap-carto.lua so that closed ways with this key will be imported as polygons, except forgolf=hole,golf=pathandgolf=cartpath, which are always mapped as linesWhile there is some debate in #661 whether rendering golf=* features in this style is appropriate, some other styles based on this one are already rendering golf=* features. Adding this key to properly import the relevant features will make it easier to adapt this stylesheet in the future.
See documentation of
golf=*values at https://wiki.openstreetmap.org/wiki/Key:golf