Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop leisure=common #3619

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

matthijsmelissen
Copy link
Collaborator

This PR drops rendering of leisure=common.

The leisure=common tag has several problems. I therefore think we should not render it on the default style.

Some of these problems are:

  • The tag defines a legal ownership concept, not a physical concept. According to the wiki, a common is 'land which has an owner, but over which other people have certain rights'. I think we should render the physical appearance or purpose of features rather than their legal status.

  • The tag is very UK centric. Commons are a UK concept that does not really translate to other countries.

  • The tag is heavily misused. At least in Western Europe, almost all objects tagged with leisure=common are not actually commons. The tag is often used for random pieces of public grass, such as those alongside roads. The fact that the tag renders nicely green on the map probably has something to do with this.

  • Other tags are available. Almost all areas that are currently tagged with leisure=common can also be tagged with other tags that are currently being rendered, such as leisure=park, landuse=grass and/or landuse=farmland.

@Adamant36
Copy link
Contributor

Id support this. Its miss used in America a lot to. I think people here just think it means any kind of "common" area. Like grass at a university. Plus I agree the tag isnt clear. leisure should be about the use case. Not the legal status. So I think removing rendering is a good idea.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 4, 2019

Related to #3305.

@Tomasz-W
Copy link

Tomasz-W commented Jan 4, 2019

Realated to #3517

I proposed color change, but dropping it at all is also good for me. Most of these areas in my neighbourhood are usually actually leisure=garden or landuse=recration_ground.

@polarbearing
Copy link
Contributor

Misused or not - dropping the rendering has the side-effect that it is also not rendered any more where it is applied correctly.
Do we have an evaluation how much of the tags are incorrect?

@polarbearing
Copy link
Contributor

Maybe changing the colour, like @Tomasz-W said, would be more reasonable. I could image the residential colour space. The current grass colour is indeed misleading.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 4, 2019 via email

@literannn
Copy link

Support dropping. In Russia mappers use this tag for everything including playgrounds, leisure spaces betwwen appartment buildings etc.

@dieterdreist
Copy link

dieterdreist commented Jan 6, 2019 via email

@Adamant36
Copy link
Contributor

Id be for also dropping nature reserve. It has the same issues as leisure=commons and I see it miss-used about as much. boundary=protected_area is a much better tag for nature reserves.

@polarbearing
Copy link
Contributor

I see it miss-used about as much

Could you support this by some numbers, e.g. the percentage of misuse against correct tagging?

@dieterdreist
Copy link

dieterdreist commented Jan 6, 2019 via email

@turnsole80
Copy link

Can I suggest dropping the landcover aspect of this tag, but not the naming?

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 8, 2019 via email

@turnsole80
Copy link

Okay, well that rather ruins my cunning plan. I figured it force mappers to make the necessary corrections, whilst still allowed for the correct usage to render where appropriate - at least until a new solution can be found.

@matthijsmelissen
Copy link
Collaborator Author

@kocio-pl Could you review this?

@kocio-pl
Copy link
Collaborator

I am not focused enough and this is quite general problem, sorry.

@kocio-pl
Copy link
Collaborator

I also think of this problem along with landuse=village_green, which makes it even broader.

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine and i agree this is a good idea.

It might however be a good idea to organize some efforts - in a similar way as with landuse=farm - to review use of the tag outside the UK.

This PR drops rendering of leisure=common.

The leisure=common tag has several problems. I therefore think we should not render it on the default style.

Some of these problems are:

* The tag defines a legal ownership concept, not a physical concept. According to the [wiki](https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dcommon), a common is 'land which has an owner, but over which other people have certain rights'. I think we should render the physical appearance or purpose of features rather than their legal status.

* The tag is very UK centric. Commons are a UK concept that does not really translate to other countries.

* The tag is heavily misused. At least in Western Europe, almost all objects tagged with leisure=common are not actually commons. The tag is often used for random pieces of public grass, such as those alongside roads. The fact that the tag renders nicely green on the map probably has something to do with this.

* Other tags are available. Almost all areas that are currently tagged with leisure=common can also be tagged with other tags that are currently being rendered, such as leisure=park, landuse=grass and/or landuse=farmland.
@matthijsmelissen matthijsmelissen merged commit 4df96c4 into gravitystorm:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants