Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop derelict_canal rendering #3174

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Conversation

sommerluk
Copy link
Collaborator

Resolves #1003

@kocio-pl
Copy link
Collaborator

Do you think it's better to just drop it now than count on wiki changes that could clarify it? There were some changes recently:

https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dderelict_canal

@sommerluk
Copy link
Collaborator Author

I think indeed that dropping now it is the best solution.

@kocio-pl
Copy link
Collaborator

I think that you're right - it can look in many ways: filled with water, intermittent water, ditch, ditch filled with plants etc., so there's no reasonable way of rendering it. Even proposed tags with prefixes still are unclear in this regard, so we need some more precise tagging to visualize it.

@kocio-pl kocio-pl merged commit b88aa83 into gravitystorm:master Apr 16, 2018
@kocio-pl
Copy link
Collaborator

Thanks, testing looks OK.

@sommerluk sommerluk deleted the derelict01 branch April 26, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants