Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving natural=tree to higher zoom #2789

Merged
merged 1 commit into from
Sep 9, 2017
Merged

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Sep 1, 2017

While natural=tree progression is nice in theory, in practice single trees do not belong to z16-z17 when tagged fully:

z16
Before
traa7lcy

After
nnvj8qkd

z17
Before
mpycct0p

After
oenwo7jg

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 9, 2017

Any comments or reviews of this PR?

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I noticed the same recently.

@kocio-pl kocio-pl merged commit 684c078 into gravitystorm:master Sep 9, 2017
@kocio-pl kocio-pl deleted the trees-z18 branch September 9, 2017 19:10
@jeisenbe
Copy link
Collaborator

jeisenbe commented Aug 24, 2019

It's a little odd that natural=tree_row now appears 2 zoom levels before natural=tree. Perhaps trees should still be shown on z17.

@kocio-pl
Copy link
Collaborator Author

Then we would have punished people for adding data in big cities, just like in the examples I have shown. Think about the forests - they are also visible much earlier than single trees and it makes sense.

I think this is not always best to use the simplest rules, unfortunately the world is much more complex. Finding the right rules is not straightforward task.

@jeisenbe
Copy link
Collaborator

The trees in the "before" pictures above fine to me. If there's a problem, it's the red, dashed footway/path lines.

Removing them from z16 was fine, especially considering how it would look nearer to the equator, but I'm not sure it made sense at z17, as long as tree rows are still rendered at z16.

@kocio-pl
Copy link
Collaborator Author

I see no problem with red paths, because they are not too dense and predictable, while single trees make visual chaos and are everywhere in this area.

I still don't get what problem do you see with progression of zoom levels forest > tree row > single tree? It's pretty natural for me that we start with complex objects and end up with single ones.

@jeisenbe
Copy link
Collaborator

Rows of trees along streets, paths, canals or between fields can either be mapped individually as natural=tree or as a single way with natural=tree_row. By showing only the latter at z16 and z17, this steers mappers towards using natural=tree_row so that the trees will render sooner. (Or alternatively, it may sometimes steer mappers to split up a tree row into individual trees, if they dislike the rendering on z16 and z17). In general, I believe this style should not give contradictory mapper feedback in this way.

@kocio-pl
Copy link
Collaborator Author

Sure, but this argument is also applicable in the case of the forest. If it's small enough and not too dense, you could represent it both ways even in practice.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Aug 25, 2019 via email

@kocio-pl
Copy link
Collaborator Author

What makes me extra cautious in every discussion is a fact that a lot of people use "tagging for rendering" not according to how it is defined. It is bad in itself, but I expect people doing some serious work, especially related to rendering - as you do for example - to never make this mistake, to make a good example for other people.

Tagging for rendering is not about choosing the tagging with specific rendering effect, which is perfectly valid case, it is only about tagging false data just to have such effect. Both tree row tagging is valid, so this is not wrong. In a matter of fact I see no perfect way to do this.

Moreover current tagging promotes row, because it is shown earlier. I would like to promote both structure and more detailed tagging (not every tree in the row has to be the same!), but in this case chaos with individual trees is critical for me, so I'm OK with single trees being less visible than row object.

@imagico
Copy link
Collaborator

imagico commented Aug 25, 2019

Tagging for rendering is not about choosing the tagging with specific rendering effect, which is perfectly valid case, it is only about tagging false data just to have such effect. Both tree row tagging is valid, so this is not wrong. In a matter of fact I see no perfect way to do this.

It does not really matter how you call it - the conclusion implied in this view, that any rendering strategy that does not specifically encourage mapping that demonstrably contradicts the observable reality is fair game, is not consensus in style development here.

The main goal of this style in terms of mapper feedback has historically been to limit itself to an affirmative role of supporting mappers in pre-existing consistent use of tags. Encouraging mappers to choosing the tagging with specific rendering effect is decidedly not part of this.

Anyway - back to the subject at hand. This change has selectively modified tree and tree row rendering (as it was previously designed in #978) by dropping rendering of individual trees from z16 and z17 while not changing anything else. A re-consideration and discussion of the overall tree rendering strategy of this style and the zoom level progression of the symbology in light of this change has not happened - which is what i have criticized in #3845.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 25, 2019

I believe it is important to use the right words for the problem to know what are we really talking about, to not make other types of error go unnoticed (like tagging for routing and so on), because this common usage twists the sense of this rule in a serious way, and to not mix encouraging (better use this than that to see it better) with forbidding (this is not going to be shown, no matter how proper it is in your opinion). I support the first one and I reject the second one most of the time.

The row case does not deny observable reality in both cases - it is an object in itself (row), but it consists of separate trees, one can observe this duality, especially if she cares for accuracy. Probably tagging for row should be better defined to let show individual trees (especially if not all of them are the same), then rendering changes can follow it, not the other way around. But this is separate thing from dot chaos, which is purely visual problem.

Of course there can be overview of tree tagging, but there are huge problems with natural=wood for example (with common different meanings) and that makes the whole idea very ambitious at best (and hopeless at worst). That solution should also allow tagging single trees in park for example, because they can look like a forest more or less, but each can have a ref (which I saw once in Berlin). And there is also the case you have shown in some ticket (I don't remember which one) with sparse trees and a grass mixed. Good luck with that, but I suppose it can easily take months or years of big discussions with no effect guaranteed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants