-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move bicycle shop icon to SVG #1281
Conversation
New icon looks to much like a motorbike to me. The proportions of bikes in icons are fairly standard, so I think trying to keep the proportions would contribute to legibility. |
@nebulon42
I think this look more natural and convincing for a generic bicycle. |
1eb6c9b
to
65c1894
Compare
Sensible suggestion for improvement. I was also thinking of moving the front part, although I couldn't shift the wheel due to the 1px padding required. I have updated the preview and PR. @althio I encourage you to to do a Pull Request at nebulon42/osmic or against the forked carto-repo if you have a similar suggestion for improvement in the future. |
65c1894
to
4ce151e
Compare
Could you expand a bit on how/what/why? I am sorry but I don't fully understand what you are proposing or how it will be more useful. Maybe I lack some GitHub insight... |
I just meant since you professionally edited my preview image, why not doing your future proposals for improvement on the SVG file and making a pull request towards the branch in my openstreetmap-carto fork. Or - even better - making a pull request at nebulon42/osmic. Just a suggestion. How will it be more useful? It's more useful for you as you immediately see if your proposed change works or not (admittedly it may be also more work). It's also incredibly more useful for me as I don't have to redo the proposed change on the icon again. |
Alright thanks for the clarification I understand your comment now. |
I see, maybe you give it a try sometime. |
I've tried to teach myself inkscape with the bike icon... it's really weird if you come from illustrator and none of the keyboard shortcuts work ;) Since I can't attach a svg, here's a "gist": and that is what it approximately looks like in 16 px: The top row starts with the official german bike sign http://de.wikipedia.org/wiki/Datei:Sinnbild_Radfahrer.svg |
Great work! It would be good if somebody else would express their preferences. The ones in the last line look quite promising to me. |
I prefer the last ones on row 1 and 3. |
Any other opinions? |
I like the last one on row 3, with the next best being the first on row 4 followed by the last on row 1, although the latter seems a bit blurrier to my eye. |
My favorites: first in row 4, last in row 3, last in row 1. Ordered by preference but differences are minor. |
same for me: first in row 4 or last in row 3. |
If it helps, there's an open source bike SVG image in this pull request: |
I have improved the aspect ratio of the bike and made the wheels thinner (see updated preview). |
Which one preview? #1281 (comment) or #1281 (comment) maybe? |
@nebulon42 would you be willing to harmonize all the bike symbols (e.g. rental, tools, shop, parking, bike traffic light)? |
@kocio-pl The preview in the first post. @brycenesbitt Apart from bike traffic light all icons you mentioned are already there, although I cannot decide about rendering. How do you consider the following icons unharmonized? bike-rental, bike repair/tools, bike parking, bike shop If you have new icon requests, feel free to open an issue at nebulon42/osmic |
@nebulon42 good artwork! Note parking-bicycle-18.svg previews with a missing handlebar. There also exist some signs for bike air such as: bike-rental unfortunately looks a lot like a common symbol for a bike locker like these: Bike rental also comes in two very different flavors |
@brycenesbitt same with car rental and car sharing. But where is the difference? both needs registration and you get a vehicle. |
Maybe that's because of too small pixel matrix. |
@HolgerJeromin we're off topic here. But car rental and car sharing are strongly different. Car rental I can walk up to with a credit card and a drivers licence and use. Car share locations are unattended and may involve a membership test, filling out forms, and receiving a special token in the mail. A map that sent me to car sharing when I'm looking for car rental has done me a disservice. @nebulon42 the icon renders without handlebar at huge size, in the SVG rendering on Mozilla Firefox. |
@brycenesbitt This is by design. This icon is designed for 16x16px size and the bike is very small. So it was necessary to omit a few details. I'm pretty sure it isn't much of an issue at the small size. Naturally, this may look weird at bigger sizes (if you open the icon the canvas is expanded to the available space). But this would require different versions for different sizes, which is currently out of scope for me. You are right for cars, but at least the bike sharing networks I know enable you to become a member on the spot pretty much the same as in your credit card scenario. But yes there is still a difference to a shop based bike rental. Anyway, I would be happy if we could return to discussing the bicycle shop icon here. Feel free to open other issues regarding bike rental vs. sharing or also car-related. |
A unifying symbol for shops has been discussed in the past. Out of scope
here, but it's definitely odd that shop is the only bike icon that does not
have an additional qualifying symbol.
|
@nebuon42 : the primary advantage of SVG is that it can render to the
resolution of your display device. If the icon was designed for 16x16
pixels, what if it's rendered on a high resolution display? All the detail
should be in the SVG, with the 16x16 pixel design as a special case.
|
@brycenesbitt What is your suggestion for an additional symbol? Re SVG: I'd not like to repeat all the discussion here, please see #632, #1165, #659 and so on. Bottom line is that even if it is SVG you still have some limitations. For the SVG to look sharp it has to be pixel-aligned and displayed at the size it is intended for. If you pack all the details in a 16x16px (or in my case 14x14px) canvas you won't be able to get a crisp representation. We're still quite off-topic here! |
Please tell me if you consider to merge the updated version, otherwise I will close this. |
One person (with a good eyesight) prefers old one as clearly better, one person (with a poor eyesight) prefers new one as clearly better. Both are clearly recognized as bicycle. Myself, I am not convinced that either new or old is clearly superior. I think that I support merging as new one is SVG and readable also for people with worse eyesight. EDIT: I caught one more person and she preferred a new symbol. |
move bicycle shop icon to SVG
@nebulon42 Thanks for your icons! |
Implements part of #1165.
Icon: nebulon42/osmic/bicycle-16.svg
before

after
