Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bowlings #3297

Closed
ghost opened this issue Jul 8, 2018 · 15 comments · Fixed by #3311
Closed

Add bowlings #3297

ghost opened this issue Jul 8, 2018 · 15 comments · Fixed by #3311

Comments

@ghost
Copy link

ghost commented Jul 8, 2018

The bowling alleys are well-known places and there are thousands all over the world. The icon should be made.

Tag: leisure=bowling_alley

@Adamant36
Copy link
Contributor

I was looking at this the other day. Its got 1764 uses. So it might be worth having an icon. There's also sport=9pin and sport=10pin that could be considered to. They have 1136 and 2277 uses respectively. There's 3,413 of them. Which is a thousand more then leisure=bowling_alley has. So they might be getting tagged with leisure=sports_centre instead of leisure=bowling_alley. Unfortunately the combinations being used with them wont show up. But at least it means there are more then just the ones tagged as leisure=bowling_alley that would potentially make it worth adding an icon. Not to mention their potential for mapping.

Any suggestions on a potential icon might help move things along

@dieterdreist
Copy link

dieterdreist commented Jul 9, 2018 via email

@Tomasz-W
Copy link

Icon proposal:

leisure bowling_alley

@Tomasz-W
Copy link

Tomasz-W commented Jul 10, 2018

I support to use the icon also for sport=9pin and sport=10pin tags.
What do you think about sport=bowls? Is it similar enough to use this icon too?

@kocio-pl kocio-pl added this to the New features milestone Jul 10, 2018
@dieterdreist
Copy link

dieterdreist commented Jul 10, 2018 via email

@Adamant36
Copy link
Contributor

I dont think it would work for sport=bowls as going by the discription the game doesnt use pins. It might be worth doing another issue for though. Especially considering its use is pretty high.

@Adamant36
Copy link
Contributor

@dieterdreist You might be right about how the sport tag should be applied, but going over some of the 9pin and 10pin key uses on Overpass Turbo it seems to be pretty varied. There's usages attached to buildings of bowling alleys, bars, hotels, sports centers and just normal buildings. So it seems like they are often used more as a property for other only vaguely related things that aren't necessarily bowling alley related or as points/areas inside other things. You can't change a hotel icon to a bowling one just because the building has sport=9pin attached to it, but that doesn't mean 9pin shouldn't have an icon either. So I don't know. I guess its something to figure out. Maybe a better definition of their tagging is needed on the wiki pages. At this point 9pin is just a stub, which probably contributed to the problem.

@dieterdreist
Copy link

dieterdreist commented Jul 11, 2018 via email

@Tomasz-W
Copy link

I didn't know about whole "properties" category: https://wiki.openstreetmap.org/wiki/Properties , but after bowling shop example I can understand the problem.

Anyway, I don't think it is an argument for not adding icons for sport=* key at all. We can distinguish them to green icon for combination with leisure=sports_centre / leisure=pitch and violet for combination with shop=*

@Tomasz-W
Copy link

@Adamant36
Copy link
Contributor

@Tomasz-W I think we should probably do the pull request for this one on its own and have seperate issues for 9pin/10pin. Since it seems like they need to be worked out seperately.

@Adamant36
Copy link
Contributor

@Tomasz-W I put in a pull request for the icon. I might be nit picking but it looks like the outline of the pin is visible between the white space in the middle and the bowling balls. It looks slightly off, but its not that bad. I still thought id give you heads up so you can check it out and modify it before it gets merged if you want to though.

@Tomasz-W
Copy link

@Adamant36 I checked the icon, everything is ok.

@kocio-pl
Copy link
Collaborator

It has 1 813 uses and a wiki page:

https://wiki.openstreetmap.org/wiki/Tag%3Aleisure%3Dbowling_alley

The icon is nice and I don't see competing tag scheme, so I'm going to merge it. Usage is increasing at high rate, so I think it's safe to do it:

taghistory 23

@Adamant36
Copy link
Contributor

@Tomasz-W Thanks. Looks ok to me too. I say its mergable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants