Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alpine_hut should have precedence over restaurant #1269

Closed
nebulon42 opened this issue Jan 30, 2015 · 5 comments · Fixed by #1349
Closed

alpine_hut should have precedence over restaurant #1269

nebulon42 opened this issue Jan 30, 2015 · 5 comments · Fixed by #1349
Labels
amenity-points
Milestone
Bugs and improvem...

Comments

@nebulon42
Copy link
Contributor

Sometimes alpine huts are both tagged tourism=alpine_hut and amenity=restaurant, which is not wrong IMO. In those cases restaurant seems to have precedence over alpine_hut, which causes the icon to appear at z17 instead of z13. This is undesirable as huts are important POIs for hikers.

Examples: http://www.openstreetmap.org/way/176377262 or http://www.openstreetmap.org/node/3007429464
@nebulon42
Copy link
Contributor Author

I have already tried to move alpine_hut after restaurant, but it didn't have any effect. How is it possible to control what rule takes precedence over the other if there is more than one match?

@matthijsmelissen
Copy link
Collaborator

It's basically the order of the arguments of COALESCE in project.yaml.

This is not an optimal situation, and any (suggestion for a) rewrite of the code to make this more easy to control is more than welcome.

@nebulon42
Copy link
Contributor Author

I see, thanks for clarification. From PostgreSQL documentation:

The COALESCE function returns the first of its arguments that is not null.

@Rovastar
Copy link
Contributor

Not sure I understand why alpine huts are restaurants. Table service.?

@polarbearing
Copy link
Contributor

Don't confuse an alpine hut with a shelter. As I understand, a hut is operated by a host, for whom serving meals is a significant part of her income, whether served at the table or picked at a counter.

This is another case that the accommodation function is seen as more important that other use, see #1232.

@matthijsmelissen matthijsmelissen added this to the Bugs and improvements milestone Feb 2, 2015
@nebulon42 nebulon42 mentioned this issue Feb 23, 2015
Closed
@daganzdaanda daganzdaanda mentioned this issue Feb 25, 2015
Closed
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 4, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
aa53e41 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
@matthijsmelissen matthijsmelissen mentioned this issue Mar 4, 2015
Merged
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 4, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
4a3dfaf 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 4, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
4933cdb 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 9, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
f93b782 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
sommerluk pushed a commit to sommerluk/openstreetmap-carto that referenced this issue Mar 16, 2015
@matthijsmelissen @sommerluk
Resolve bugs related to COALESCE problems
fa1128f 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
amenity-points
Projects
None yet
Milestone
Bugs and improvements
Development

Successfully merging a pull request may close this issue.

Resolve bugs related to COALESCE problems matthijsmelissen/openstreetmap-carto
4 participants
@nebulon42 @Rovastar @matthijsmelissen @polarbearing